mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jie Yu" <yujie....@gmail.com>
Subject Re: Review Request 35229: Report per-container metrics for network bandwidth throttling to the slave.
Date Wed, 17 Jun 2015 20:58:06 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35229/#review88275
-----------------------------------------------------------

Ship it!


Please do a rebase.


src/slave/containerizer/isolators/network/port_mapping.cpp (line 696)
<https://reviews.apache.org/r/35229/#comment140710>

    Could you please move that to the top of this file? Also, please use fully qualified namespace
    ```
    using namespace routing::queueing::statistics;
    ```



src/slave/containerizer/isolators/network/port_mapping.cpp (line 703)
<https://reviews.apache.org/r/35229/#comment140711>

    Please use
    ```
    statistics[BACKLOG];
    ```



src/slave/containerizer/isolators/network/port_mapping.cpp (line 750)
<https://reviews.apache.org/r/35229/#comment140713>

    s/results/result/ to be consistent with others.



src/slave/containerizer/isolators/network/port_mapping.cpp (line 869)
<https://reviews.apache.org/r/35229/#comment140712>

    Can you create a temporary variable since it's used in more than one places:
    ```
    const string& eth0 = flags.eth0_name.get();
    ```



src/slave/containerizer/isolators/network/port_mapping.cpp (line 879)
<https://reviews.apache.org/r/35229/#comment140714>

    enter?


- Jie Yu


On June 17, 2015, 7:25 p.m., Paul Brett wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35229/
> -----------------------------------------------------------
> 
> (Updated June 17, 2015, 7:25 p.m.)
> 
> 
> Review request for mesos, Chi Zhang, Ian Downes, Jie Yu, and Cong Wang.
> 
> 
> Bugs: MESOS-2836
>     https://issues.apache.org/jira/browse/MESOS-2836
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Report per-container metrics for network bandwidth throttling to the slave.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/isolators/network/port_mapping.hpp 4c719b186b519fad0c3869dbdae8b60c3a2c20cc

>   src/slave/containerizer/isolators/network/port_mapping.cpp e55e7b62bc29125458f9c0fb5477057ecc5a90df

> 
> Diff: https://reviews.apache.org/r/35229/diff/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Paul Brett
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message