mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexander Rojas" <alexan...@mesosphere.io>
Subject Re: Review Request 30032: Added support for cache control in libprocess when dealing with static files.
Date Wed, 17 Jun 2015 15:42:22 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30032/
-----------------------------------------------------------

(Updated June 17, 2015, 5:42 p.m.)


Review request for mesos, Benjamin Hindman, Bernd Mathiske, Joerg Schad, Michael Park, and
Till Toenshoff.


Changes
-------

Addresses Bernd's review


Bugs: mesos-708
    https://issues.apache.org/jira/browse/mesos-708


Repository: mesos


Description
-------

When serving a static file, libprocess returns the header `Last-Modified` which is used by
browsers to control Cache.
When a http request arrives containing the header `If-Modified-Since`, a response `304 Not
Modified` is returned if the date in the request and the modification time (as returned by
doing `stat` in the file) coincide.
Unit tests added.


Diffs (updated)
-----

  3rdparty/libprocess/include/process/http.hpp e47cc7afbc8110759edf25a2dc05d09eda25c417 
  3rdparty/libprocess/src/process.cpp a67a3afdb30d23eb1b265b04ae662f64e874b6c6 
  3rdparty/libprocess/src/tests/process_tests.cpp 660af45e7fd45bdf5d43ad9aa54477fd94f87058


Diff: https://reviews.apache.org/r/30032/diff/


Testing
-------

make check


Thanks,

Alexander Rojas


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message