mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexander Rojas" <alexan...@mesosphere.io>
Subject Re: Review Request 34703: Added stream manipulators for the Time object.
Date Tue, 16 Jun 2015 12:24:16 GMT


> On June 16, 2015, 10:29 a.m., Bernd Mathiske wrote:
> > 3rdparty/libprocess/src/time.cpp, line 41
> > <https://reviews.apache.org/r/34703/diff/5/?file=984729#file984729line41>
> >
> >     Why can't we use strfmt_l with a locale argument that matches the output we
want?

`strfmt_l` is available only on OS X.


> On June 16, 2015, 10:29 a.m., Bernd Mathiske wrote:
> > 3rdparty/libprocess/src/time.cpp, line 42
> > <https://reviews.apache.org/r/34703/diff/5/?file=984729#file984729line42>
> >
> >     s/the RFC 1123/RFC1123

Here is not talking about the struct `RFC11123` but to the actual [RFC 1123](https://www.ietf.org/rfc/rfc1123.txt)


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34703/#review88038
-----------------------------------------------------------


On June 16, 2015, 2:24 p.m., Alexander Rojas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34703/
> -----------------------------------------------------------
> 
> (Updated June 16, 2015, 2:24 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Michael Park, Nikita Vetoshkin, and Till Toenshoff.
> 
> 
> Bugs: mesos-708
>     https://issues.apache.org/jira/browse/mesos-708
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Adds some manipulator classes which allows formatting Time objects to ostreams.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/Makefile.am c781f6ca38d87c47b4bdadf5ac2f59a02dd8c73c 
>   3rdparty/libprocess/include/process/time.hpp c5ab2a3cfa83590eb6612152ae365dd67f51cea9

>   3rdparty/libprocess/src/tests/time_tests.cpp be314182c65c05d439b81aa5248a71d93f6f0a0b

>   3rdparty/libprocess/src/time.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/34703/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message