mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jiang Yan Xu" <...@jxu.me>
Subject Re: Review Request 35118: Made updateSlave() update its 'totalResources'.
Date Tue, 09 Jun 2015 18:42:45 GMT


> On June 9, 2015, 10:36 a.m., Niklas Nielsen wrote:
> > src/master/master.cpp, line 3511
> > <https://reviews.apache.org/r/35118/diff/1/?file=980131#file980131line3511>
> >
> >     Isn't this a bit harsh? Shouldn't we log a warning and return instead? Also,
could this be done earlier on?

Harshness: I think it's fine a) because it's internal communication not involving the frameworks
and b) it's a new message handler so backwards compatibility is covered.


Done earlier on: Agreed, will change this in a new review. (This one is already committed,
sorry I haven't flagged it as such).


> On June 9, 2015, 10:36 a.m., Niklas Nielsen wrote:
> > src/master/master.cpp, lines 3513-3514
> > <https://reviews.apache.org/r/35118/diff/1/?file=980131#file980131line3513>
> >
> >     Does it make sense to point to some documentation (if it exists already, or
inline) about how this resource math will work?

Can you suggest something here?

FWIW I also updated the comment on `totalResources`:
```
  // The current total resources of the slave. Note that this is
  // different from 'info.resources()' because this also considers
  // operations (e.g., CREATE, RESERVE) that have been applied and
  // includes revocable resources as well.
  Resources totalResources;
```


- Jiang Yan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35118/#review87234
-----------------------------------------------------------


On June 5, 2015, 2:09 p.m., Jiang Yan Xu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35118/
> -----------------------------------------------------------
> 
> (Updated June 5, 2015, 2:09 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-2776
>     https://issues.apache.org/jira/browse/MESOS-2776
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> - This way Master::Slave::totalResources includes revocable resources, which we need
for metrics for revocable resources.
> - Changed updateSlave() argument to use `const Resources& oversubscribedResources`
instead of `const std::vector<Resource>& oversubscribedResources` because `Resources`
provides convenience methods such as `revocable()`.
> 
> 
> Diffs
> -----
> 
>   src/master/master.hpp deeb0d8c87a13315206556e1d0974cdd13e8224f 
>   src/master/master.cpp be0db42da3c59761aa154439653d715556465256 
> 
> Diff: https://reviews.apache.org/r/35118/diff/
> 
> 
> Testing
> -------
> 
> make check.
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message