mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ben Mahler" <benjamin.mah...@gmail.com>
Subject Re: Review Request 35118: Made updateSlave() update its 'totalResources'.
Date Tue, 09 Jun 2015 01:35:52 GMT


> On June 5, 2015, 9:58 p.m., Vinod Kone wrote:
> > src/master/master.cpp, line 3462
> > <https://reviews.apache.org/r/35118/diff/1/?file=980131#file980131line3462>
> >
> >     woah. didn't realize this was handled automagically by the install handler.

Yeah, we didn't do this for framework provided input since the construction to 'Resources'
is lossy, and we wanted to validate, but looks good here! Just good to keep in mind that doing
this means we cannot do a `Resources::validate` on this.


- Ben


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35118/#review86850
-----------------------------------------------------------


On June 5, 2015, 9:09 p.m., Jiang Yan Xu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35118/
> -----------------------------------------------------------
> 
> (Updated June 5, 2015, 9:09 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-2776
>     https://issues.apache.org/jira/browse/MESOS-2776
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> - This way Master::Slave::totalResources includes revocable resources, which we need
for metrics for revocable resources.
> - Changed updateSlave() argument to use `const Resources& oversubscribedResources`
instead of `const std::vector<Resource>& oversubscribedResources` because `Resources`
provides convenience methods such as `revocable()`.
> 
> 
> Diffs
> -----
> 
>   src/master/master.hpp deeb0d8c87a13315206556e1d0974cdd13e8224f 
>   src/master/master.cpp be0db42da3c59761aa154439653d715556465256 
> 
> Diff: https://reviews.apache.org/r/35118/diff/
> 
> 
> Testing
> -------
> 
> make check.
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message