mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "haosdent huang" <haosd...@gmail.com>
Subject Re: Review Request 33339: Add a Java example framework to test persistent volumes.
Date Sun, 07 Jun 2015 08:16:02 GMT


> On June 1, 2015, 11:32 p.m., Marco Massenzio wrote:
> > This is great -sorry it took so long to get to do a review.
> > 
> > Thanks for doing it, I'm quite looking forward to using it to learning more about
the Persistent Framework :)
> > it would be great if we could have a bit more comments in the code to help all other
newbies.
> > 
> > My review was fairly narrowly focused on Java style etc. - I'm expecting one of
the commiters will be able to give you feedback about using the framework.
> 
> Jie Yu wrote:
>     Sorry, this is my fault. I really don't have cycle for this at this moment. Marco,
mind sherperding this patch?
> 
> Jie Yu wrote:
>     The logic of this patch should match that in src/examples/persistent_volume_framework.cpp
> 
> Marco Massenzio wrote:
>     Jie - I would be absolutely happy to do that, with one minor hitch: I'm not a committer
:)
>     Happy to help out wherever I can, though!
> 
> haosdent huang wrote:
>     Thank you very much for your review, let me update it. @marco

@marco Thank you for your review again. But some logic are follow the exists Java examples
and persistent_volume_framework.cpp . I am not sure change it are correct or not. Anyway,
I think I need to reflect this patch to make it more clear. After I reflect it, I would @you
and looking forward your review again. Thanks a lot.


- haosdent


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33339/#review86113
-----------------------------------------------------------


On June 7, 2015, 8:10 a.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33339/
> -----------------------------------------------------------
> 
> (Updated June 7, 2015, 8:10 a.m.)
> 
> 
> Review request for mesos, Jie Yu and Vinod Kone.
> 
> 
> Bugs: MESOS-2610
>     https://issues.apache.org/jira/browse/MESOS-2610
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Add a Java example framework to test persistent volumes.
> 
> 
> Diffs
> -----
> 
>   configure.ac cad7f0e92eacc86d37b3f578382946db8b466531 
>   src/Makefile.am ec7f41f2114d02d3d5a1434d9799f15fe9331917 
>   src/examples/java/TestPersistentVolumeFramework.java PRE-CREATION 
>   src/examples/java/test-persistent-volume-framework.in PRE-CREATION 
>   src/tests/examples_tests.cpp f85b81562158c5499e9804d8d7b6811bb0a3ef16 
>   src/tests/java_persistent_volume_framework_test.sh PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/33339/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message