mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jie Yu" <yujie....@gmail.com>
Subject Re: Review Request 34720: Added kill executor correction to slave.
Date Thu, 04 Jun 2015 18:33:06 GMT


> On June 4, 2015, 5:58 p.m., Vinod Kone wrote:
> > src/slave/slave.cpp, lines 4400-4413
> > <https://reviews.apache.org/r/34720/diff/3/?file=979257#file979257line4400>
> >
> >     This is getting a little hairy. As the TODO says we really ought bubble this
up via the Termination protobuf. Have you looked into it?
> 
> Jie Yu wrote:
>     +1
>     
>     It really gets nasty here. I remembered that jaybuff said that they plan to fix that.
Maybe you want to sync with them first.
> 
> Niklas Nielsen wrote:
>     Mind adding a few references? Where is the Termination proto?

Some references for the context:
https://issues.apache.org/jira/browse/MESOS-2035
https://reviews.apache.org/r/33249/ (see discussions in the review)
https://issues.apache.org/jira/browse/MESOS-2657


- Jie


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34720/#review86669
-----------------------------------------------------------


On June 4, 2015, 5:43 p.m., Niklas Nielsen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34720/
> -----------------------------------------------------------
> 
> (Updated June 4, 2015, 5:43 p.m.)
> 
> 
> Review request for mesos, Bartek Plotka, Jie Yu, Joris Van Remoortere, and Vinod Kone.
> 
> 
> Bugs: MESOS-2653
>     https://issues.apache.org/jira/browse/MESOS-2653
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary
> 
> 
> Diffs
> -----
> 
>   src/slave/slave.hpp 37e85af90275dc0c88c12b39a5813e7d71abb1f3 
>   src/slave/slave.cpp 30e0d8ba2a2b12a0a7f1f7246b65360de30ef4ea 
> 
> Diff: https://reviews.apache.org/r/34720/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Niklas Nielsen
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message