-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35043/#review86551
-----------------------------------------------------------
Patch looks great!
Reviews applied: [34687, 35043]
All tests passed.
- Mesos ReviewBot
On June 4, 2015, 4:27 a.m., Marco Massenzio wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35043/
> -----------------------------------------------------------
>
> (Updated June 4, 2015, 4:27 a.m.)
>
>
> Review request for mesos, Isabel Jimenez, Joris Van Remoortere, and Vinod Kone.
>
>
> Bugs: MESOS-2340
> https://issues.apache.org/jira/browse/MESOS-2340
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Jira: MESOS-2340
>
> The Leader detector will now also try to
> read nodes with label master::MASTER_INFO_JSON_LABEL
> and parse the contents as JSON, converting the data
> to a mesos::MasterInfo protobuf.
>
> The ability to support binary data in PB format is
> still supported and the master::Contender will continue
> to serialize the binary data, so as to be compatible with
> pre-0.23 Mesos Masters.
>
> From 0.24 onwards, we will only support JSON data written to ZK.
>
>
> Diffs
> -----
>
> src/master/constants.hpp 57cf8fbeff203847b5b5442f6c78ca9c09bcc66d
> src/master/constants.cpp 8c7174a9940bd332832bf85d81ab13cf11836dd0
> src/master/detector.cpp 5700711771480f4e5da88e60657618c955f10048
>
> Diff: https://reviews.apache.org/r/35043/diff/
>
>
> Testing
> -------
>
> make check
> (this is still WIP - need to add unit tests for the new JSON format)
>
> Also see manual testing results in https://issues.apache.org/jira/browse/MESOS-2340
>
>
> Thanks,
>
> Marco Massenzio
>
>
|