mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jie Yu" <yujie....@gmail.com>
Subject Re: Review Request 34748: Defined protobuf for usage returned by Resource Monitor. Reused ResourceUsage. Pass ResourceUsage to ResourceEstimator
Date Mon, 01 Jun 2015 22:01:10 GMT


> On June 1, 2015, 9:58 p.m., Jie Yu wrote:
> > include/mesos/mesos.proto, line 578
> > <https://reviews.apache.org/r/34748/diff/3/?file=975577#file975577line578>
> >
> >     I think we also need to know the total resources allocated to the container.
For instance, one may want to know the usage slack.
> 
> Niklas Nielsen wrote:
>     Totally - thought we would do this in a subsequent patch :)

SGTM.


- Jie


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34748/#review86098
-----------------------------------------------------------


On June 1, 2015, 9:26 p.m., Bartek Plotka wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34748/
> -----------------------------------------------------------
> 
> (Updated June 1, 2015, 9:26 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Jie Yu, Joris Van Remoortere, Niklas Nielsen, Szymon
Konefal, and Vinod Kone.
> 
> 
> Bugs: MESOS-2772
>     https://issues.apache.org/jira/browse/MESOS-2772
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Changed ResourceMonitor to use ResourceUsage instead of ResourceMonitor::Usage.
> Reused old ResoureUsage in message mesos.proto
> 
> NOTE: That is required for modules which need to fetch ResourceUsage e.g ResourceEstimator
and QoSController.
> Discussed that message ResourceUsage in mesos.proto is free to reuse and modify, since
it's not used anywhere else.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto a66888916dc90e476c8bb20e67e3f6b08c47fb99 
>   src/slave/monitor.hpp 48fe59faacf53f1015665b0867aefd08d5b29225 
>   src/slave/monitor.cpp a5a52b116ec38535dcc23e720e8a3a1fbc73762e 
> 
> Diff: https://reviews.apache.org/r/34748/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Bartek Plotka
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message