mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "haosdent huang" <haosd...@gmail.com>
Subject Re: Review Request 34362: Include ExecutorInfos in master/state.json
Date Mon, 01 Jun 2015 17:09:15 GMT


> On June 1, 2015, 8:53 a.m., Adam B wrote:
> > Looks good, but it's missing a few performance tricks we've used in other json model()
functions, to reduce the json construction time, especially for large clusters. We should
do some quick benchmarking on a cluster with thousands of (simulated) executors to see how
much overhead this adds to state.json.

@adam-mesos, thank you very much for you explain and your help. I would try to simulate thousands
of executors and upload the test result later. Maybe need after a few days.


- haosdent


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34362/#review85959
-----------------------------------------------------------


On June 1, 2015, 5:06 p.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34362/
> -----------------------------------------------------------
> 
> (Updated June 1, 2015, 5:06 p.m.)
> 
> 
> Review request for mesos and Adam B.
> 
> 
> Bugs: MESOS-2743
>     https://issues.apache.org/jira/browse/MESOS-2743
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Include ExecutorInfos in master/state.json
> 
> 
> Diffs
> -----
> 
>   src/common/http.hpp afce7fea334c7bfa57efc48c413bf906a2ebde32 
>   src/common/http.cpp 2ac7fba7a3aac913540f1b09768777393b79284a 
>   src/master/http.cpp 01dbdad9720a9cd30505683ae1117970cda918a0 
>   src/slave/http.cpp b5e77b09435e50db5231a2b32faf76dab91dae54 
> 
> Diff: https://reviews.apache.org/r/34362/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> haosdent huang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message