Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 8517418C64 for ; Thu, 28 May 2015 18:41:39 +0000 (UTC) Received: (qmail 84910 invoked by uid 500); 28 May 2015 18:41:39 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 84888 invoked by uid 500); 28 May 2015 18:41:39 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 84871 invoked by uid 99); 28 May 2015 18:41:39 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 28 May 2015 18:41:39 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 0CE611DDB16; Thu, 28 May 2015 18:41:38 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============0039932362168684363==" MIME-Version: 1.0 Subject: Re: Review Request 34748: Defined protobuf for usage returned by Resource Monitor. Reused ResourceUsage. Pass ResourceUsage to ResourceEstimator From: "Bartek Plotka" To: "Joris Van Remoortere" , "Niklas Nielsen" , "Szymon Konefal" , "Jie Yu" , "Vinod Kone" Cc: "Bartek Plotka" , "mesos" , "Mesos ReviewBot" Date: Thu, 28 May 2015 18:41:38 -0000 Message-ID: <20150528184138.8660.68771@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Bartek Plotka" X-ReviewGroup: mesos X-ReviewRequest-URL: https://reviews.apache.org/r/34748/ X-Sender: "Bartek Plotka" References: <20150528023755.8660.90103@reviews.apache.org> In-Reply-To: <20150528023755.8660.90103@reviews.apache.org> Reply-To: "Bartek Plotka" X-ReviewRequest-Repository: mesos --===============0039932362168684363== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34748/ ----------------------------------------------------------- (Updated May 28, 2015, 6:41 p.m.) Review request for mesos, Jie Yu, Joris Van Remoortere, Niklas Nielsen, Szymon Konefal, and Vinod Kone. Changes ------- This patch is depended on RE modularization. Summary (updated) ----------------- Defined protobuf for usage returned by Resource Monitor. Reused ResourceUsage. Pass ResourceUsage to ResourceEstimator Bugs: MESOS-2772 https://issues.apache.org/jira/browse/MESOS-2772 Repository: mesos Description ------- Changed ResourceMonitor to use ResourceUsage instead of ResourceMonitor::Usage. Reused old ResoureUsage in message mesos.proto NOTE: That is required for modules which need to fetch ResourceUsage e.g ResourceEstimator and QoSController. Discussed that message ResourceUsage in mesos.proto is free to reuse and modify, since it's not used anywhere else. Diffs ----- include/mesos/mesos.proto a66888916dc90e476c8bb20e67e3f6b08c47fb99 src/slave/monitor.hpp 48fe59faacf53f1015665b0867aefd08d5b29225 src/slave/monitor.cpp a5a52b116ec38535dcc23e720e8a3a1fbc73762e Diff: https://reviews.apache.org/r/34748/diff/ Testing ------- make check Thanks, Bartek Plotka --===============0039932362168684363==--