Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 27F0A18575 for ; Wed, 13 May 2015 06:14:21 +0000 (UTC) Received: (qmail 26399 invoked by uid 500); 13 May 2015 06:14:21 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 26377 invoked by uid 500); 13 May 2015 06:14:21 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 26365 invoked by uid 99); 13 May 2015 06:14:20 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 13 May 2015 06:14:20 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 59D801DD354; Wed, 13 May 2015 06:14:21 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============3700387975043755884==" MIME-Version: 1.0 Subject: Re: Review Request 34152: Master flag validation now supports zookeeper From: "Mesos ReviewBot" To: "Tom Arnfeld" , "Mesos ReviewBot" , "mesos" Date: Wed, 13 May 2015 06:14:21 -0000 Message-ID: <20150513061421.18931.88747@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Mesos ReviewBot" X-ReviewGroup: mesos X-ReviewRequest-URL: https://reviews.apache.org/r/34152/ X-Sender: "Mesos ReviewBot" References: <20150513020819.12558.13523@reviews.apache.org> In-Reply-To: <20150513020819.12558.13523@reviews.apache.org> Reply-To: "Mesos ReviewBot" X-ReviewRequest-Repository: mesos --===============3700387975043755884== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34152/#review83568 ----------------------------------------------------------- Patch looks great! Reviews applied: [34152] All tests passed. - Mesos ReviewBot On May 13, 2015, 2:08 a.m., Tom Arnfeld wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34152/ > ----------------------------------------------------------- > > (Updated May 13, 2015, 2:08 a.m.) > > > Review request for mesos. > > > Bugs: MESOS-2723 > https://issues.apache.org/jira/browse/MESOS-2723 > > > Repository: mesos > > > Description > ------- > > The mesos-execute cli tool does custom validation on the --master flag > to improve user error handling, but currently does not support ZooKeeper. > > > Diffs > ----- > > src/cli/execute.cpp dbd19e67f56a150f54180ad13e6402842eb68e17 > > Diff: https://reviews.apache.org/r/34152/diff/ > > > Testing > ------- > > Compiled and tested locally on a live cluster, with both ZooKeeper and standalone host:port. > > > Thanks, > > Tom Arnfeld > > --===============3700387975043755884==--