Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id E0E11174AD for ; Thu, 7 May 2015 18:34:25 +0000 (UTC) Received: (qmail 56382 invoked by uid 500); 7 May 2015 18:34:25 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 56362 invoked by uid 500); 7 May 2015 18:34:25 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 56346 invoked by uid 99); 7 May 2015 18:34:25 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 07 May 2015 18:34:25 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id C98AC1DD201; Thu, 7 May 2015 18:34:26 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============5416301167930788047==" MIME-Version: 1.0 Subject: Re: Review Request 33490: MESOS-2633 Avoid adding duplicate tasks From: "Ben Mahler" To: "Joris Van Remoortere" , "Adam B" Cc: "Marco Massenzio" , "Ben Mahler" , "mesos" Date: Thu, 07 May 2015 18:34:26 -0000 Message-ID: <20150507183426.1563.51012@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Ben Mahler" X-ReviewGroup: mesos X-ReviewRequest-URL: https://reviews.apache.org/r/33490/ X-Sender: "Ben Mahler" References: <20150507082642.1563.92895@reviews.apache.org> In-Reply-To: <20150507082642.1563.92895@reviews.apache.org> Reply-To: "Ben Mahler" X-ReviewRequest-Repository: mesos --===============5416301167930788047== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33490/#review82867 ----------------------------------------------------------- Hm, I looked at MESOS-2633, that's only about moving implementation out? Could we get some more context on this change? What motivated it? Is there a bug? When can it occur? What happens if it does? - Ben Mahler On May 7, 2015, 8:26 a.m., Marco Massenzio wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33490/ > ----------------------------------------------------------- > > (Updated May 7, 2015, 8:26 a.m.) > > > Review request for mesos, Adam B and Joris Van Remoortere. > > > Bugs: MESOS-2633 > https://issues.apache.org/jira/browse/MESOS-2633 > > > Repository: mesos > > > Description > ------- > > In Framework::addCompletedTask(const Task& task) we did not check > for duplicated tasks, so they could be added more than once. > > A simple check has now been added (there still is the issue > of whether the `operator ==` on `Task` is too strict, so as > never to cause a match). > > > Diffs > ----- > > src/master/framework.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/33490/diff/ > > > Testing > ------- > > buildbot make check pass > http://build.mesosphere.com:5555/builders/dev_test/builds/13 > > > Thanks, > > Marco Massenzio > > --===============5416301167930788047==--