Return-Path: X-Original-To: apmail-mesos-reviews-archive@minotaur.apache.org Delivered-To: apmail-mesos-reviews-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id CAC1D10FCD for ; Wed, 6 May 2015 00:52:04 +0000 (UTC) Received: (qmail 33640 invoked by uid 500); 6 May 2015 00:52:04 -0000 Delivered-To: apmail-mesos-reviews-archive@mesos.apache.org Received: (qmail 33616 invoked by uid 500); 6 May 2015 00:52:04 -0000 Mailing-List: contact reviews-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: reviews@mesos.apache.org Delivered-To: mailing list reviews@mesos.apache.org Received: (qmail 33598 invoked by uid 99); 6 May 2015 00:52:04 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 06 May 2015 00:52:04 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 7D69F1DBECF; Wed, 6 May 2015 00:52:03 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============1178148945439997448==" MIME-Version: 1.0 Subject: Re: Review Request 33643: Add EMPTY to stout hashset From: "Cody Maloney" To: "Benjamin Hindman" Cc: "Joris Van Remoortere" , "mesos" , "Cody Maloney" Date: Wed, 06 May 2015 00:52:03 -0000 Message-ID: <20150506005203.8788.37147@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: "Cody Maloney" X-ReviewGroup: mesos X-ReviewRequest-URL: https://reviews.apache.org/r/33643/ X-Sender: "Cody Maloney" References: <20150505215059.20177.60659@reviews.apache.org> In-Reply-To: <20150505215059.20177.60659@reviews.apache.org> Reply-To: "Cody Maloney" X-ReviewRequest-Repository: mesos --===============1178148945439997448== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33643/#review82624 ----------------------------------------------------------- 3rdparty/libprocess/3rdparty/stout/include/stout/hashset.hpp Any reason we can't do this as a function with a static in it? Solves the destruction order issues, doesn't leak, doesn't require the constant reference. - Cody Maloney On May 5, 2015, 9:50 p.m., Joris Van Remoortere wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33643/ > ----------------------------------------------------------- > > (Updated May 5, 2015, 9:50 p.m.) > > > Review request for mesos and Benjamin Hindman. > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/hashset.hpp d2b74393b7c4b65477698d9c810dfe3c8673c2ab > > Diff: https://reviews.apache.org/r/33643/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Joris Van Remoortere > > --===============1178148945439997448==--