mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mesos ReviewBot" <revi...@mesos.apache.org>
Subject Re: Review Request 33159: Pump updateFramework through Allocator from Master.
Date Sat, 30 May 2015 00:15:03 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33159/#review85844
-----------------------------------------------------------


Patch looks great!

Reviews applied: [32961, 33159]

All tests passed.

- Mesos ReviewBot


On May 29, 2015, 10:41 p.m., Joris Van Remoortere wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33159/
> -----------------------------------------------------------
> 
> (Updated May 29, 2015, 10:41 p.m.)
> 
> 
> Review request for mesos and Benjamin Hindman.
> 
> 
> Bugs: MESOS-2615 and MESOS-703
>     https://issues.apache.org/jira/browse/MESOS-2615
>     https://issues.apache.org/jira/browse/MESOS-703
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Follow up of 32961 where we add the 'updateFramework' function to the allocator.
> 
> 
> Diffs
> -----
> 
>   include/mesos/master/allocator.hpp 8347cfaf6abce155a777484970e595e6b141bb87 
>   src/master/allocator/mesos/allocator.hpp b57b03daf992082ec7c731666699ab2574bf7993 
>   src/master/allocator/mesos/hierarchical.hpp 44fbccaf72b65251095f69b68627d0efa58707d4

>   src/master/master.cpp 710b8149c9d855d0f47cb2952366be10bc78c74d 
>   src/tests/mesos.hpp ac986a0687a576a0bd5693c82b3c7d543aaa956b 
> 
> Diff: https://reviews.apache.org/r/33159/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message