mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexander Rojas" <alexan...@mesosphere.io>
Subject Re: Review Request 30032: Added support for cache control in libprocess when dealing with static files.
Date Tue, 26 May 2015 14:41:42 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30032/
-----------------------------------------------------------

(Updated May 26, 2015, 4:41 p.m.)


Review request for mesos, Benjamin Hindman, Bernd Mathiske, Joerg Schad, Michael Park, and
Till Toenshoff.


Changes
-------

Bernd's reviews.


Bugs: mesos-708
    https://issues.apache.org/jira/browse/mesos-708


Repository: mesos


Description
-------

When serving a static file, libprocess returns the header `Last-Modified` which is used by
browsers to control Cache.
When a http request arrives containing the header `If-Modified-Since`, a response `304 Not
Modified` is returned if the date in the request and the modification time (as returned by
doing `stat` in the file) coincide.
Unit tests added.


Diffs (updated)
-----

  3rdparty/libprocess/include/process/http.hpp bba62b393dc863e724cb602b1504eb6517ae9730 
  3rdparty/libprocess/src/process.cpp e3de3cd6b536aaaf59784360aed546512dd04dc9 
  3rdparty/libprocess/src/tests/process_tests.cpp 67e582cc250a9767a389e2bd0cc68985477f3ffb


Diff: https://reviews.apache.org/r/30032/diff/


Testing
-------

make check


Thanks,

Alexander Rojas


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message