mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Till Toenshoff" <toensh...@me.com>
Subject Re: Review Request 30032: Added support for cache control in libprocess when dealing with static files.
Date Mon, 18 May 2015 19:53:42 GMT


> On March 26, 2015, 4:59 p.m., Benjamin Hindman wrote:
> > 3rdparty/libprocess/src/process.cpp, line 2854
> > <https://reviews.apache.org/r/30032/diff/4/?file=834184#file834184line2854>
> >
> >     Result<Time> time = Path(response.path).mtime();
> 
> Alexander Rojas wrote:
>     This cannot be implemented in terms on `Time`, since `Path` is part of stout and
`Time` belongs to libprocess.

Seems `Time` actually should be a stout class.


- Till


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30032/#review69827
-----------------------------------------------------------


On April 20, 2015, 11:58 a.m., Alexander Rojas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30032/
> -----------------------------------------------------------
> 
> (Updated April 20, 2015, 11:58 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Bernd Mathiske, Joerg Schad, Michael Park,
and Till Toenshoff.
> 
> 
> Bugs: mesos-708
>     https://issues.apache.org/jira/browse/mesos-708
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> When serving a static file, libprocess returns the header `Last-Modified` which is used
by browsers to control Cache.
> When a http request arrives containing the header `If-Modified-Since`, a response `304
Not Modified` is returned if the date in the request and the modification time (as returned
by doing `stat` in the file) coincide.
> Unit tests added.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/http.hpp 07825b2b7195fe7fe752e8fda65b7f0a8b8b1f38

>   3rdparty/libprocess/src/process.cpp 97ac09fd10b767bc46387abc3657d005a00830c8 
>   3rdparty/libprocess/src/tests/process_tests.cpp eb38edce2c483ba7f963a826893a15a075238618

> 
> Diff: https://reviews.apache.org/r/30032/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message