mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vinod Kone" <vinodk...@gmail.com>
Subject Re: Review Request 33865: Added RevocableInfo message to Resource protobuf.
Date Fri, 15 May 2015 23:28:19 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33865/
-----------------------------------------------------------

(Updated May 15, 2015, 11:28 p.m.)


Review request for mesos, Jie Yu, Joris Van Remoortere, and Niklas Nielsen.


Changes
-------

jie's and nik's comments. PTAL.


Bugs: MESOS-2691
    https://issues.apache.org/jira/browse/MESOS-2691


Repository: mesos


Description
-------

RevocableInfo currently supports OVERSUBSCRIBED resources. In the future it can be easily
extended to use other types of revocable reosurces (e.g., resources allocated to other roles).

Disabled the ability to use revocable resources for reservation or persistence because the
semantics seem weird. We can enable it in the future if there is a use case for that.


Diffs (updated)
-----

  include/mesos/mesos.proto 15f55a3c54be3475e77d561f106e00ea6e53c2fa 
  src/common/resources.cpp 843a06d6c4d3e9ff0d1665360bae7c57bcfecb83 
  src/master/validation.cpp c3e96ae0e684f3f365e9aa365bccc953d32b0452 
  src/tests/master_validation_tests.cpp 9a6f4fa464d6daca088c8634e73e04c5fd380677 
  src/tests/resources_tests.cpp a7ec59ea217ad71f7d1e93ca6039d5b2491b3237 

Diff: https://reviews.apache.org/r/33865/diff/


Testing
-------

make check


Thanks,

Vinod Kone


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message