mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benjamin Hindman" <b...@berkeley.edu>
Subject Re: Review Request 29889: Recover Docker containers when mesos slave is in a container
Date Fri, 15 May 2015 18:58:19 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29889/#review83952
-----------------------------------------------------------



src/slave/containerizer/docker.cpp
<https://reviews.apache.org/r/29889/#comment135009>

    Let's use Flags here so that we don't have to manually construct the command string.



src/slave/containerizer/docker.cpp
<https://reviews.apache.org/r/29889/#comment135012>

    then(defer(self(), [=]() { return launchDockerRun(containerId, containerName); }))
    
    then(defer(self(), &Self::launchDockerRun, containerId, containerName))
    
    then(defer(self(), lambda::bind(&Self::launchDockerRun, containerId, containerName)))
    
    launchDockerRun(...)
    {
      ...
      return docker->run();
    }



src/tests/docker_containerizer_tests.cpp
<https://reviews.apache.org/r/29889/#comment135018>

    const&



src/tests/docker_containerizer_tests.cpp
<https://reviews.apache.org/r/29889/#comment135017>

    ASSERT_SOME(read);
    vector<string> lines = strings::split(read.get());
    
    EXPECT_TRUE(Collection(lines).exists([=](const string& line) { return line == "err"
+ uuid; });
    
    EXPECT_TRUE(Collection(lines).exists(line));
    
    EXPECT_TRUE(containsLine(lines, "err" + uuid));
    
    Collection(strings::split(read.get()))
      .exists([](const string& line) {
        return line == ("err" + uuid);
      });


- Benjamin Hindman


On May 14, 2015, 9:39 p.m., Timothy Chen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29889/
> -----------------------------------------------------------
> 
> (Updated May 14, 2015, 9:39 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Bernd Mathiske, and Till Toenshoff.
> 
> 
> Bugs: MESOS-2115
>     https://issues.apache.org/jira/browse/MESOS-2115
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This is a one mega patch and contains many reviews that's already on rb.
> 
> This review is not meant to be merged, only provided for easier review.
> 
> 
> Diffs
> -----
> 
>   Dockerfile 35abf25 
>   docs/configuration.md 54c4e31 
>   docs/docker-containerizer.md a5438b7 
>   src/Makefile.am 34755cf 
>   src/docker/docker.hpp 3ebbc1f 
>   src/docker/docker.cpp 3a485a2 
>   src/docker/executor.cpp PRE-CREATION 
>   src/slave/constants.hpp df02043 
>   src/slave/constants.cpp 07f699a 
>   src/slave/containerizer/docker.hpp ed4ee19 
>   src/slave/containerizer/docker.cpp 408a443 
>   src/slave/flags.hpp ca7cc13 
>   src/slave/flags.cpp f35c76a 
>   src/tests/docker_containerizer_tests.cpp 154bf98 
> 
> Diff: https://reviews.apache.org/r/29889/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message