mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Marco Massenzio" <ma...@mesosphere.io>
Subject Re: Review Request 33823: Protocol file with the HTTP API messages between executor and slave
Date Sat, 09 May 2015 02:31:19 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33823/#review83128
-----------------------------------------------------------



include/mesos/executor/executor.hpp
<https://reviews.apache.org/r/33823/#comment133995>

    not sure whether this is common practice in Mesos - if so, please feel free to ignore
this comment.
    
    I find it confusing that this include file is named exactly as /mesos/executor.hpp - there
is nothing (for the uninitiated) to indicate that this is just a 'shell' around the Protobuf
generated include: not the location, not the name, not nothing - and it has the same name
as a completely different include.
    
    Again, if this is the way it is, so be it - if not, please consider renaming it something
more meaningful?


- Marco Massenzio


On May 4, 2015, 10:21 p.m., Alexander Rojas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33823/
> -----------------------------------------------------------
> 
> (Updated May 4, 2015, 10:21 p.m.)
> 
> 
> Review request for mesos, Isabel Jimenez, Marco Massenzio, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   include/mesos/executor/executor.hpp PRE-CREATION 
>   include/mesos/executor/executor.proto PRE-CREATION 
>   src/Makefile.am 93c7c8a807a33ab639be6289535bbd32022aa85b 
> 
> Diff: https://reviews.apache.org/r/33823/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message