mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joerg Schad" <jo...@mesosphere.io>
Subject Re: Review Request 33276: Fix capture by reference of temporaries in Libprocess.
Date Thu, 07 May 2015 18:55:21 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33276/#review82873
-----------------------------------------------------------

Ship it!


Maybe we could use benchmark to ensure the overall change does not cause a noticable performance
penalty (don't think so, but numbers are always good to verify)

- Joerg Schad


On April 22, 2015, 6:11 p.m., Joris Van Remoortere wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33276/
> -----------------------------------------------------------
> 
> (Updated April 22, 2015, 6:11 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Cody Maloney, Joerg Schad, Michael Park, and
Till Toenshoff.
> 
> 
> Bugs: MESOS-2631
>     https://issues.apache.org/jira/browse/MESOS-2631
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/gmock.hpp a99eb8ae8fedef2b7d9e227afb3c101f82f753db

>   3rdparty/libprocess/src/http.cpp eed42ad2725d56ef8c000c1bdedcdc6063ad28c9 
>   3rdparty/libprocess/src/process.cpp 97ac09fd10b767bc46387abc3657d005a00830c8 
>   3rdparty/libprocess/src/tests/process_tests.cpp eb38edce2c483ba7f963a826893a15a075238618

>   3rdparty/libprocess/src/tests/reap_tests.cpp a18d54c43fba44d084e722abdc67d32e5d4504e4

> 
> Diff: https://reviews.apache.org/r/33276/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message