> On May 5, 2015, 4:29 p.m., Cody Maloney wrote:
> > configure.ac, line 575
> > <https://reviews.apache.org/r/33849/diff/1/?file=950367#file950367line575>
> >
> > Can you check ax_cxx_compiler_version >= Clang/LLVM 3.5 here? Or does that
not work on both OS X and Linux?
Hmm. I don't have a Linux system with clang 3.5 and I'm not quite sure what you are asking
here. I do have a later version of OS X clang and this change works (and automatically disables
unused local typedef warnings).
I tried to leave the compiler logic alone in this patch since I don't have systems to test
all the possible combinations. I agree that it would be desirable to separate the typedef
warnings from the compiler versions (though I was confused that GCC and clang seem to have
subtly different names for the same warning). I'm happy to knock up a separate patch for that
if you like.
- James
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33849/#review82524
-----------------------------------------------------------
On May 5, 2015, 3:53 p.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33849/
> -----------------------------------------------------------
>
> (Updated May 5, 2015, 3:53 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Cody Maloney, and Timothy St. Clair.
>
>
> Bugs: MESOS-2666
> https://issues.apache.org/jira/browse/MESOS-2666
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Import the AX_COMPILER_VERSION and AX_COMPILER_VENDOR macros from
> the autoconf archive and use them to detect and configure the
> supported copmilers.
>
>
> Diffs
> -----
>
> configure.ac 14658f6f6920549f1948b8bd8890c67bc067e3dd
> m4/ax_compiler_vendor.m4 PRE-CREATION
> m4/ax_compiler_version.m4 PRE-CREATION
>
> Diff: https://reviews.apache.org/r/33849/diff/
>
>
> Testing
> -------
>
> Make check on CentOS 7 and Mac OS X 10.10.3. Verified that the default CentOS 6 GCC toolchain
is still rejected as too old.
>
>
> Thanks,
>
> James Peach
>
>
|