mesos-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benjamin Bannier (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MESOS-9382) mesos-gtest-runner doesn't work on systems without ulimit binary
Date Fri, 09 Nov 2018 22:41:00 GMT

    [ https://issues.apache.org/jira/browse/MESOS-9382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16682021#comment-16682021
] 

Benjamin Bannier commented on MESOS-9382:
-----------------------------------------

{noformat}
commit 5367851e0e399d718df8f529ad977b6afd74bf99
Author: Benjamin Bannier <bbannier@apache.org>
Date:   Fri Nov 9 21:50:42 2018 +0100

    Fixed parallel test runner ulimit check for setups without limits.
    
    This patch adds special handling for the case where no process rlimit
    is in effect. For that we explicitly handle an output `unlimited`
    which can be present in e.g., `C` locales.
    
    Review: https://reviews.apache.org/r/69306

commit 9df27e3657aa44677668baaee70e46b7963b06e4
Author: Chun-Hung Hsiao <chhsiao@apache.org>
Date:   Fri Nov 9 11:47:01 2018 -0800

    Fixed the ulimit validation in the parallel test runner.
    
    This patch fixes the following error:
    ```
    $ support/mesos-gtest-runner.py build/bin/mesos-tests.sh
    Could not check compatibility of ulimit settings: \
    [Errno 2] No such file or directory: 'ulimit': 'ulimit'
    ```
    
    Review: https://reviews.apache.org/r/69301/
{noformat}

> mesos-gtest-runner doesn't work on systems without ulimit binary
> ----------------------------------------------------------------
>
>                 Key: MESOS-9382
>                 URL: https://issues.apache.org/jira/browse/MESOS-9382
>             Project: Mesos
>          Issue Type: Bug
>          Components: test
>            Reporter: Ilya Pronin
>            Assignee: Benjamin Bannier
>            Priority: Major
>
> {{mesos-gtest-runner.py}} fails on systems without a separate ulimit binary (i.e. CentOS
7).
> {noformat}
> /home/ipronin/mesos/build/../support/mesos-gtest-runner.py --sequential=*ROOT_* ./mesos-tests
> Could not check compatibility of ulimit settings: [Errno 2] No such file or directory:
'ulimit'
> {noformat}
> The problem arises in [this call|https://github.com/apache/mesos/blob/630d8938462381e8e7b0f44fa6434e47460fb178/support/mesos-gtest-runner.py#L209].
Seems that it can be fixed by passing a {{shell=True}} argument to {{subprocess.check_output()}}.
> Another problem is {{ROOT_*}} tests which should be ran as root. For root {{ulimit -u}}
will most likely return "unlimited", which will again crash the runner.
> {noformat}
> Could not check compatibility of ulimit settings: invalid literal for int() with base
10: b'unlimited\n'
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message