mesos-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chun-Hung Hsiao (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MESOS-9369) Avoid blocking `Future::get()` calls
Date Sun, 04 Nov 2018 04:20:00 GMT

    [ https://issues.apache.org/jira/browse/MESOS-9369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16674292#comment-16674292
] 

Chun-Hung Hsiao commented on MESOS-9369:
----------------------------------------

[~bmahler] I'm already kinda doing a sweep (not finished yet though). Currently I only see
HDFS using this.
>From the consistency point of view, I also think [~bbannier]'s suggestion is better.

However, if we consider libprocess as a standalone library, [~alexr] is worried about that
we're introducing a breaking change.
Still, the proposed plan above is still a breaking change, but it seems slightly less intrusive.

> Avoid blocking `Future::get()` calls
> ------------------------------------
>
>                 Key: MESOS-9369
>                 URL: https://issues.apache.org/jira/browse/MESOS-9369
>             Project: Mesos
>          Issue Type: Improvement
>          Components: libprocess
>            Reporter: Chun-Hung Hsiao
>            Assignee: Chun-Hung Hsiao
>            Priority: Major
>              Labels: libprocess
>
> {{Future::get()}} does a wait if the future is still pending. If this is accidentally
called in an actor, the actor will be blocked. We should avoid calling {{Future::get()}} in
the code. The plan would be:
>  # Introduce {{Future::value()}}: crash if not READY
>  # Make {{Future::operator*}} and {{Future::operator->}} akin to {{Future::value()}}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message