mesos-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chun-Hung Hsiao (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (MESOS-9228) SLRP does not clean up plugin containers after it is removed.
Date Sat, 22 Sep 2018 06:46:00 GMT

    [ https://issues.apache.org/jira/browse/MESOS-9228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16624534#comment-16624534
] 

Chun-Hung Hsiao edited comment on MESOS-9228 at 9/22/18 6:45 AM:
-----------------------------------------------------------------

{noformat}
commit 0581437999a262277f695592c6a1be9d30bf8c31
Author: Chun-Hung Hsiao <chhsiao@mesosphere.io>
Date: Tue Sep 18 12:59:52 2018 -0700

Removed unnecessary failure handling in agent HTTP API handlers.

The current agent HTTP API handlers either unnecessarily handle failures
on always-ready futures, or return "500 Internal Server Error"
unnecessarily. This patch removes those unnecessarily code.

Review: https://reviews.apache.org/r/68755{noformat}
{noformat}
commit 1adceaacc81bb33332a52a9f28a864ac928ac706
Author: Chun-Hung Hsiao <chhsiao@mesosphere.io>
Date: Tue Sep 18 14:40:55 2018 -0700

Performed RP-specific validations when adding/updating RP configs.

Each type of RP might have some specific validations for RP info. For
example, SLRP requires the `storage` field to be set. This patch makes
the local RP daemon to perform such validations when adding/updating
configs, so the `ADD_RESOURCE_PROVIDER_CONFIG` and
`UPDATE_RESOURCE_PROVIDER_CONFIG` calls can fail fast.

Review: https://reviews.apache.org/r/68756{noformat}
{noformat}
commit ae41c14e47dd09db82fb237a9987fde8e100c8be
Author: Chun-Hung Hsiao <chhsiao@mesosphere.io>
Date: Tue Sep 18 11:54:29 2018 -0700

Removed `ROOT` requirements for `AgentResourceProviderConfigApiTest`.

These tests required `ROOT` in order to use `filesystem/linux`
isolation this is not a requirement anymore so we can run the tests in
general. These tests appear to be able to run in parallel as well.

We also changed the `AddConflict` test a bit to make it more robust.

Review: https://reviews.apache.org/r/68757{noformat}
{noformat}
commit c174b9d3a7eb842b6de66256f0373c5e12b00cce
Author: Chun-Hung Hsiao <chhsiao@mesosphere.io>
Date: Wed Sep 19 18:07:50 2018 -0700

Set master/agent flags in `AgentResourceProviderConfigApiTest` fixture.

Review: https://reviews.apache.org/r/68777{noformat}
{noformat}
commit a31509e4206edc12fbc7ed6a8e8f87c36e02f34d
Author: Chun-Hung Hsiao <chhsiao@mesosphere.io>
Date: Tue Sep 18 13:25:06 2018 -0700

Added unit tests for adding/updating invalid resource provider configs.

Review: https://reviews.apache.org/r/68758{noformat}
{noformat}
commit 88b28f2cd900a53a8d54b7be837ccc9813e3b764
Author: Chun-Hung Hsiao <chhsiao@mesosphere.io>
Date: Thu Sep 20 11:25:11 2018 -0700

Moved the container ID prefix generation to `LocalResourceProvider`.

It is more reasonable to not allow each specific resource provider to
construct their own container ID prefix, otherwise it would be hard to
avoid conflicts. Therefore we now established the convension of how the
prefix is constructed in `LocalResourceProvider`.

Review: https://reviews.apache.org/r/68790{noformat}
{noformat}
commit 6366b5c1e5e60dfda5ca0368d6a22da998f0cfa4
Author: Chun-Hung Hsiao <chhsiao@mesosphere.io>
Date: Thu Sep 20 15:06:51 2018 -0700

Cleaned up residual containers when removing resource provider configs.

When processing `REMOVE_RESOURCE_PROVIDER_CONFIG`, the local resource
provider daemon now performs a best-effort cleanup by killing all
standalone containers prefixed by the 'cid_prefix' of the resource
provider. During the cleanup, no resource provider config with the same
type and name can be added.

Review: https://reviews.apache.org/r/68763{noformat}
{noformat}
commit 678fa8b44bc9c09f5f9908a3a4511f7195150d7b
Author: Chun-Hung Hsiao <chhsiao@mesosphere.io>
Date: Tue Sep 18 21:40:35 2018 -0700

Tested container cleanup in `AgentResourceProviderConfigApiTest.Remove`.

Review: https://reviews.apache.org/r/68762{noformat}
 


was (Author: chhsia0):
{noformat}
commit 0581437999a262277f695592c6a1be9d30bf8c31
Author: Chun-Hung Hsiao <chhsiao@mesosphere.io>
Date: Tue Sep 18 12:59:52 2018 -0700

Removed unnecessary failure handling in agent HTTP API handlers.

The current agent HTTP API handlers either unnecessarily handle failures
on always-ready futures, or return "500 Internal Server Error"
unnecessarily. This patch removes those unnecessarily code.

Review: https://reviews.apache.org/r/68755{noformat}
{noformat}
commit 1adceaacc81bb33332a52a9f28a864ac928ac706
Author: Chun-Hung Hsiao <chhsiao@mesosphere.io>
Date: Tue Sep 18 14:40:55 2018 -0700

Performed RP-specific validations when adding/updating RP configs.

Each type of RP might have some specific validations for RP info. For
example, SLRP requires the `storage` field to be set. This patch makes
the local RP daemon to perform such validations when adding/updating
configs, so the `ADD_RESOURCE_PROVIDER_CONFIG` and
`UPDATE_RESOURCE_PROVIDER_CONFIG` calls can fail fast.

Review: https://reviews.apache.org/r/68756{noformat}
{noformat}
commit ae41c14e47dd09db82fb237a9987fde8e100c8be
Author: Chun-Hung Hsiao <chhsiao@mesosphere.io>
Date: Tue Sep 18 11:54:29 2018 -0700

Removed `ROOT` requirements for `AgentResourceProviderConfigApiTest`.

These tests required `ROOT` in order to use `filesystem/linux`
isolation this is not a requirement anymore so we can run the tests in
general. These tests appear to be able to run in parallel as well.

We also changed the `AddConflict` test a bit to make it more robust.

Review: https://reviews.apache.org/r/68757{noformat}
{noformat}
commit c174b9d3a7eb842b6de66256f0373c5e12b00cce
Author: Chun-Hung Hsiao <chhsiao@mesosphere.io>
Date: Wed Sep 19 18:07:50 2018 -0700

Set master/agent flags in `AgentResourceProviderConfigApiTest` fixture.

Review: https://reviews.apache.org/r/68777{noformat}
{noformat}
commit a31509e4206edc12fbc7ed6a8e8f87c36e02f34d
Author: Chun-Hung Hsiao <chhsiao@mesosphere.io>
Date: Tue Sep 18 13:25:06 2018 -0700

Added unit tests for adding/updating invalid resource provider configs.

Review: https://reviews.apache.org/r/68758{noformat}
{noformat}
commit 88b28f2cd900a53a8d54b7be837ccc9813e3b764
Author: Chun-Hung Hsiao <chhsiao@mesosphere.io>
Date: Thu Sep 20 11:25:11 2018 -0700

Moved the container ID prefix generation to `LocalResourceProvider`.

It is more reasonable to not allow each specific resource provider to
construct their own container ID prefix, otherwise it would be hard to
avoid conflicts. Therefore we now established the convension of how the
prefix is constructed in `LocalResourceProvider`.

Review: https://reviews.apache.org/r/68790{noformat}
{noformat}
commit 6366b5c1e5e60dfda5ca0368d6a22da998f0cfa4
Author: Chun-Hung Hsiao <chhsiao@mesosphere.io>
Date: Thu Sep 20 15:06:51 2018 -0700

Cleaned up residual containers when removing resource provider configs.

When processing `REMOVE_RESOURCE_PROVIDER_CONFIG`, the local resource
provider daemon now performs a best-effort cleanup by killing all
standalone containers prefixed by the 'cid_prefix' of the resource
provider. During the cleanup, no resource provider config with the same
type and name can be added.

Review: https://reviews.apache.org/r/68763{noformat}
{noformat}
commit 678fa8b44bc9c09f5f9908a3a4511f7195150d7b (ci/ci/chhsiao/slrp)
Author: Chun-Hung Hsiao <chhsiao@mesosphere.io>
Date: Tue Sep 18 21:40:35 2018 -0700

Tested container cleanup in `AgentResourceProviderConfigApiTest.Remove`.

Review: https://reviews.apache.org/r/68762{noformat}
 

> SLRP does not clean up plugin containers after it is removed.
> -------------------------------------------------------------
>
>                 Key: MESOS-9228
>                 URL: https://issues.apache.org/jira/browse/MESOS-9228
>             Project: Mesos
>          Issue Type: Bug
>          Components: storage
>    Affects Versions: 1.5.0, 1.6.0, 1.7.0
>            Reporter: Chun-Hung Hsiao
>            Assignee: Chun-Hung Hsiao
>            Priority: Blocker
>              Labels: mesosphere, storage
>             Fix For: 1.7.1, 1.8.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message