From issues-return-48667-archive-asf-public=cust-asf.ponee.io@mesos.apache.org Tue Aug 28 22:18:05 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 3FAD9180621 for ; Tue, 28 Aug 2018 22:18:05 +0200 (CEST) Received: (qmail 93369 invoked by uid 500); 28 Aug 2018 20:18:04 -0000 Mailing-List: contact issues-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@mesos.apache.org Delivered-To: mailing list issues@mesos.apache.org Received: (qmail 93321 invoked by uid 99); 28 Aug 2018 20:18:04 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 28 Aug 2018 20:18:04 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id DFAD9C06AD for ; Tue, 28 Aug 2018 20:18:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.251 X-Spam-Level: X-Spam-Status: No, score=-109.251 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, KAM_LOTSOFHASH=0.25, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id FVvb9dVmGy5B for ; Tue, 28 Aug 2018 20:18:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id BADEF5F16A for ; Tue, 28 Aug 2018 20:18:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id D94CCE2613 for ; Tue, 28 Aug 2018 20:18:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 374FC26B5D for ; Tue, 28 Aug 2018 20:18:00 +0000 (UTC) Date: Tue, 28 Aug 2018 20:18:00 +0000 (UTC) From: "Alexander Rukletsov (JIRA)" To: issues@mesos.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Comment Edited] (MESOS-9158) Batch state-related read-only requests in the Master actor. MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/MESOS-9158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16595547#comment-16595547 ] Alexander Rukletsov edited comment on MESOS-9158 at 8/28/18 8:17 PM: --------------------------------------------------------------------- {noformat} commit 4118a482a95793252f4713c5e20ef2c70f2ab07b Author: Benno Evers AuthorDate: Tue Aug 28 21:25:52 2018 +0200 Commit: Alexander Rukletsov CommitDate: Tue Aug 28 21:25:52 2018 +0200 Added '/state-summary' to the set of batched master endpoints. Review: https://reviews.apache.org/r/68321/ {noformat} {noformat} commit 63e9096b0cd883d9edc8907a577bcba0b150b541 Author: Benno Evers AuthorDate: Tue Aug 28 21:26:03 2018 +0200 Commit: Alexander Rukletsov CommitDate: Tue Aug 28 21:26:03 2018 +0200 Added '/tasks' to the set of batched master endpoints. Review: https://reviews.apache.org/r/68440/ {noformat} {noformat} commit 33c38c9baa20b42562b519971df508283d988abc Author: Benno Evers AuthorDate: Tue Aug 28 21:26:11 2018 +0200 Commit: Alexander Rukletsov CommitDate: Tue Aug 28 21:26:11 2018 +0200 Added '/slaves' to the set of batched master endpoints. Review: https://reviews.apache.org/r/68441/ {noformat} {noformat} commit 102dcca4e0116d2ffbdcd78d998e032841ffbabe Author: Benno Evers AuthorDate: Tue Aug 28 21:26:18 2018 +0200 Commit: Alexander Rukletsov CommitDate: Tue Aug 28 21:26:18 2018 +0200 Added '/frameworks' to the set of batched master endpoints. Review: https://reviews.apache.org/r/68442/ {noformat} {noformat} commit 44e523490b394e6c43bce8b5304996137d176f96 Author: Benno Evers AuthorDate: Tue Aug 28 21:26:25 2018 +0200 Commit: Alexander Rukletsov CommitDate: Tue Aug 28 21:26:25 2018 +0200 Moved members of `ReadOnlyHandler` into separate file. Moved the member functions of class `ReadOnlyHandler` into the new file `readonly_handler.cpp`. This follows the pattern established by `weights_handler.cpp` and `quota_handler.cpp`. As part of this move, it was also necessary to move some JSON serialization that are used from both `master.cpp` and `readonly_handler.cpp` to a new pair of files `json.{cpp,hpp}` that can be used from both places. Review: https://reviews.apache.org/r/68473/ {noformat} {noformat} commit 4930ec2e141920411fb9050500f385f5ef6a78a2 Author: Benno Evers AuthorDate: Tue Aug 28 21:26:36 2018 +0200 Commit: Alexander Rukletsov CommitDate: Tue Aug 28 21:49:41 2018 +0200 Cleaned up some style issues in `ReadOnlyHandler`. This commit fixes several minor style issues: - Sorted member function declarations of `ReadOnlyHandler` alphabetically. - Added notes to remind readers of the fact that requests to certain endpoints are batched. - Changed captured variable in `/frameworks` endpoint handler. Review: https://reviews.apache.org/r/68537/ {noformat} was (Author: alexr): {noformat} commit 4118a482a95793252f4713c5e20ef2c70f2ab07b Author: Benno Evers AuthorDate: Tue Aug 28 21:25:52 2018 +0200 Commit: Alexander Rukletsov CommitDate: Tue Aug 28 21:25:52 2018 +0200 Added '/state-summary' to the set of batched master endpoints. Review: https://reviews.apache.org/r/68321/ {noformat} {noformat} commit 63e9096b0cd883d9edc8907a577bcba0b150b541 Author: Benno Evers AuthorDate: Tue Aug 28 21:26:03 2018 +0200 Commit: Alexander Rukletsov CommitDate: Tue Aug 28 21:26:03 2018 +0200 Added '/tasks' to the set of batched master endpoints. Review: https://reviews.apache.org/r/68440/ {noformat} {noformat} commit 33c38c9baa20b42562b519971df508283d988abc Author: Benno Evers AuthorDate: Tue Aug 28 21:26:11 2018 +0200 Commit: Alexander Rukletsov CommitDate: Tue Aug 28 21:26:11 2018 +0200 Added '/slaves' to the set of batched master endpoints. Review: https://reviews.apache.org/r/68441/ {noformat} {noformat} commit 102dcca4e0116d2ffbdcd78d998e032841ffbabe Author: Benno Evers AuthorDate: Tue Aug 28 21:26:18 2018 +0200 Commit: Alexander Rukletsov CommitDate: Tue Aug 28 21:26:18 2018 +0200 Added '/frameworks' to the set of batched master endpoints. Review: https://reviews.apache.org/r/68442/ {format} {format} commit 44e523490b394e6c43bce8b5304996137d176f96 Author: Benno Evers AuthorDate: Tue Aug 28 21:26:25 2018 +0200 Commit: Alexander Rukletsov CommitDate: Tue Aug 28 21:26:25 2018 +0200 Moved members of `ReadOnlyHandler` into separate file. Moved the member functions of class `ReadOnlyHandler` into the new file `readonly_handler.cpp`. This follows the pattern established by `weights_handler.cpp` and `quota_handler.cpp`. As part of this move, it was also necessary to move some JSON serialization that are used from both `master.cpp` and `readonly_handler.cpp` to a new pair of files `json.{cpp,hpp}` that can be used from both places. Review: https://reviews.apache.org/r/68473/ {noformat} {noformat} commit 4930ec2e141920411fb9050500f385f5ef6a78a2 Author: Benno Evers AuthorDate: Tue Aug 28 21:26:36 2018 +0200 Commit: Alexander Rukletsov CommitDate: Tue Aug 28 21:49:41 2018 +0200 Cleaned up some style issues in `ReadOnlyHandler`. This commit fixes several minor style issues: - Sorted member function declarations of `ReadOnlyHandler` alphabetically. - Added notes to remind readers of the fact that requests to certain endpoints are batched. - Changed captured variable in `/frameworks` endpoint handler. Review: https://reviews.apache.org/r/68537/ {noformat} > Batch state-related read-only requests in the Master actor. > ----------------------------------------------------------- > > Key: MESOS-9158 > URL: https://issues.apache.org/jira/browse/MESOS-9158 > Project: Mesos > Issue Type: Improvement > Components: master > Reporter: Alexander Rukletsov > Assignee: Benno Evers > Priority: Major > Labels: mesosphere, performance > > Similar to MESOS-9122, make all read-only master state endpoints batched. -- This message was sent by Atlassian JIRA (v7.6.3#76005)