mesos-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Till Toenshoff (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MESOS-7397) apply-reviews.py silently fails when using chain mode.
Date Tue, 10 Jul 2018 17:36:00 GMT

    [ https://issues.apache.org/jira/browse/MESOS-7397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16539006#comment-16539006
] 

Till Toenshoff commented on MESOS-7397:
---------------------------------------

{noformat}
commit 997e280b57232b5f9b12e0e9dfd0abfc9d6c1085 (HEAD -> master)
Author: Till Toenshoff toenshoff@me.com
Date:   Tue Jul 10 19:33:58 2018 +0200

Updated apply-reviews.py messaging for submitted reviews.

Review: https://reviews.apache.org/r/67859/
{noformat}

> apply-reviews.py silently fails when using chain mode.
> ------------------------------------------------------
>
>                 Key: MESOS-7397
>                 URL: https://issues.apache.org/jira/browse/MESOS-7397
>             Project: Mesos
>          Issue Type: Bug
>            Reporter: Till Toenshoff
>            Priority: Minor
>             Fix For: 1.7.0
>
>
> When using {{apply-reviews.py}} in chain mode {{--chain}} it suppresses error messages
when patches do not apply.
> Example on {{1.0.x}}:
> {noformat}
> $ ./support/apply-reviews.py -c -r 57764
> $
> {noformat} 
> If used without chain mode, the error message is properly displayed:
> {noformat}
> $ ./support/apply-reviews.py -r 57764
> 2017-04-18 11:45:58 URL:https://reviews.apache.org/r/57764/diff/raw/ [1067/1067] ->
"57764.patch" [1]
> error: patch failed: src/launcher/posix/executor.cpp:116
> error: src/launcher/posix/executor.cpp: patch does not apply
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message