From issues-return-47614-archive-asf-public=cust-asf.ponee.io@mesos.apache.org Sun May 13 18:51:04 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id B4099180636 for ; Sun, 13 May 2018 18:51:03 +0200 (CEST) Received: (qmail 49108 invoked by uid 500); 13 May 2018 16:51:02 -0000 Mailing-List: contact issues-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@mesos.apache.org Delivered-To: mailing list issues@mesos.apache.org Received: (qmail 49095 invoked by uid 99); 13 May 2018 16:51:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 13 May 2018 16:51:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 46CDDCD49E for ; Sun, 13 May 2018 16:51:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.501 X-Spam-Level: X-Spam-Status: No, score=-109.501 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id lKclmHiIWDbY for ; Sun, 13 May 2018 16:51:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 6FE895F21E for ; Sun, 13 May 2018 16:51:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id C8DA4E0047 for ; Sun, 13 May 2018 16:51:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 18FAF2179F for ; Sun, 13 May 2018 16:51:00 +0000 (UTC) Date: Sun, 13 May 2018 16:51:00 +0000 (UTC) From: "Shubham Kumar (JIRA)" To: issues@mesos.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Assigned] (MESOS-8905) Remove a redundant resource update for the executor launched as a Docker container MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/MESOS-8905?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shubham Kumar reassigned MESOS-8905: ------------------------------------ Assignee: Shubham Kumar > Remove a redundant resource update for the executor launched as a Docker container > ---------------------------------------------------------------------------------- > > Key: MESOS-8905 > URL: https://issues.apache.org/jira/browse/MESOS-8905 > Project: Mesos > Issue Type: Bug > Components: docker > Reporter: Qian Zhang > Assignee: Shubham Kumar > Priority: Major > > In `DockerContainerizerProcess::_launch` we have these codes: > {code:java} > Future DockerContainerizerProcess::_launch( > const ContainerID& containerId, > const ContainerConfig& containerConfig) > { > ... > .then(defer(self(), [=]() { > return launchExecutorContainer(containerId, containerName); > })) > .then(defer(self(), [=](const Docker::Container& dockerContainer) { > // Call update to set CPU/CFS/mem quotas at launch. > // TODO(steveniemitz): Once the minimum docker version supported > // is >= 1.7 this can be changed to pass --cpu-period and > // --cpu-quota to the 'docker run' call in > // launchExecutorContainer. > return update( > containerId, containerConfig.executor_info().resources(), true) > .then([=]() { > return Future(dockerContainer); > }); > })) > ... > {code} > With the fix to MESOS-6134, `launchExecutorContainer` will launch the executor as a Docker container and set its CPU quota accordingly, so we do not need the subsequent call to `update` to update the Docker container's resources again, actually it is already mentioned in the TODO above the call to `update`. So we should remove the call to `update` and also the TODO. -- This message was sent by Atlassian JIRA (v7.6.3#76005)