From issues-return-47470-archive-asf-public=cust-asf.ponee.io@mesos.apache.org Wed May 2 04:29:04 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 03C81180645 for ; Wed, 2 May 2018 04:29:03 +0200 (CEST) Received: (qmail 55132 invoked by uid 500); 2 May 2018 02:29:02 -0000 Mailing-List: contact issues-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@mesos.apache.org Delivered-To: mailing list issues@mesos.apache.org Received: (qmail 55123 invoked by uid 99); 2 May 2018 02:29:02 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 02 May 2018 02:29:02 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id E7E391A06D3 for ; Wed, 2 May 2018 02:29:01 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -101.511 X-Spam-Level: X-Spam-Status: No, score=-101.511 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id 8MhwgyzxabiU for ; Wed, 2 May 2018 02:29:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 01AF35F23C for ; Wed, 2 May 2018 02:29:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 84D4FE0350 for ; Wed, 2 May 2018 02:29:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 0EDF121297 for ; Wed, 2 May 2018 02:29:00 +0000 (UTC) Date: Wed, 2 May 2018 02:29:00 +0000 (UTC) From: "Andrew Schwartzmeyer (JIRA)" To: issues@mesos.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (MESOS-8676) Fix os::read and os::write to use HANDLES MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/MESOS-8676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16460432#comment-16460432 ] Andrew Schwartzmeyer commented on MESOS-8676: --------------------------------------------- This issue now covers replacing the CRT API with an overlapped compatible API. Adding the overlapped part is MESOS-8670. > Fix os::read and os::write to use HANDLES > ----------------------------------------- > > Key: MESOS-8676 > URL: https://issues.apache.org/jira/browse/MESOS-8676 > Project: Mesos > Issue Type: Task > Reporter: Andrew Schwartzmeyer > Assignee: Andrew Schwartzmeyer > Priority: Major > Labels: stout, windows > > When fixing {{os::open}} to open real Windows {{HANDLE}} s to files in a default overlapped mode, we'll need to fix {{os::read}} and {{os::write}} to work with these. Since these functions are inherently synchronous, we'll just use overlapped I/O but wait for completion, making the action synchronous. > Caveat: when files on Windows are opened in overlapped mode, they no longer retain state about the offset. Because these functions currently use the CRT APIs {{_read}} and {{_write}}, they act like POSIX file descriptors which are advanced by N bytes per read and write. We can mimic this behavior by saving the offset state in the {{WindowsFD}} abstraction. > Also fix use of {{WSAGetLastError}} since not all reads/writes are on sockets. -- This message was sent by Atlassian JIRA (v7.6.3#76005)