mesos-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jie Yu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MESOS-8651) Potential memory leaks in the `volume/sandbox_path` isolator
Date Fri, 16 Mar 2018 23:57:00 GMT

    [ https://issues.apache.org/jira/browse/MESOS-8651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16403136#comment-16403136
] 

Jie Yu commented on MESOS-8651:
-------------------------------

commit 28ecf0c865347f75b90992a919ec7c56edb93eae (HEAD -> master, origin/master, origin/HEAD)
Author: Jason Lai <jason@jasonlai.net>
Date:   Fri Mar 16 16:45:00 2018 -0700

    Fixed potential memory leak in the `volume/sandbox_path` isolator.

    The `volume/sandbox_path` isolator inserts a string of the sandbox path
    to its `sandboxes` hashmap instance variable upon the launch of each
    container. However, it never cleans it up properly and can cause
    unbounded growth of the hashmap object, as isolators are global
    singleton objects.

    The patch ensures the sandbox path associated with a given container ID
    gets removed from the `sandboxes` hashmap upon container cleanup.

    Review: https://reviews.apache.org/r/66104/

> Potential memory leaks in the `volume/sandbox_path` isolator
> ------------------------------------------------------------
>
>                 Key: MESOS-8651
>                 URL: https://issues.apache.org/jira/browse/MESOS-8651
>             Project: Mesos
>          Issue Type: Bug
>          Components: containerization
>            Reporter: Jason Lai
>            Assignee: Jason Lai
>            Priority: Major
>              Labels: easyfix, patch
>             Fix For: 1.6.0
>
>
> The {{sandboxes}} hashmap object of {{mesos::internal::slave::VolumeSandboxPathIsolatorProcess}}
bears the risk of potential memory leak.
> It [adds the sandbox path upon each container launch|https://github.com/apache/mesos/blob/1.5.x/src/slave/containerizer/mesos/isolators/volume/sandbox_path.cpp#L119-L122]
and does not remove the sandbox path after cleaning up the container. As the life cycle of
an isolator is attached to that of {{MesosContainerizer}}, this means that more and more sandbox
paths will get added to the {{sandboxes}} hashmap object, as Mesos containers keep being launched
and will likely blow up Mesos agent eventually.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message