mesos-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Schwartzmeyer (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MESOS-8556) Boost emits warning repeatedly
Date Wed, 14 Mar 2018 18:47:00 GMT

    [ https://issues.apache.org/jira/browse/MESOS-8556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16399088#comment-16399088
] 

Andrew Schwartzmeyer commented on MESOS-8556:
---------------------------------------------

So, this patch is fairly temporary. The tip of {{develop}} of Boost (of that submodule) has
this commit:

{noformat}
commit 5ad073063 (origin/develop, origin/HEAD, develop)
Author: jzmaddock <john@johnmaddock.co.uk>
Date:   Wed Mar 7 18:02:01 2018 +0000

    visualc.hpp: Disable warning about outdated config.

diff --git a/include/boost/config/compiler/visualc.hpp b/include/boost/config/compiler/visualc.hpp
index 748d14076..c533c50df 100644
--- a/include/boost/config/compiler/visualc.hpp
+++ b/include/boost/config/compiler/visualc.hpp
@@ -346,6 +346,9 @@
 #  if defined(BOOST_ASSERT_CONFIG)
 #     error "Boost.Config is older than your current compiler version."
 #  elif !defined(BOOST_CONFIG_SUPPRESS_OUTDATED_MESSAGE)
-      BOOST_PRAGMA_MESSAGE("Info: Boost.Config is older than your compiler version - probably
nothing bad will happen - but you may wish to look for an updated Boost vers
ion. Define BOOST_CONFIG_SUPPRESS_OUTDATED_MESSAGE to suppress this message.")
+      //
+      // Disabled as of March 2018 - the pace of VS releases is hard to keep up with
+      // and in any case, we have relatively few defect macros defined now.
+      // BOOST_PRAGMA_MESSAGE("Info: Boost.Config is older than your compiler version - probably
nothing bad will happen - but you may wish to look for an updated Boost v
ersion. Define BOOST_CONFIG_SUPPRESS_OUTDATED_MESSAGE to suppress this message.")
 #  endif
 #endif
{noformat}

So when we get an updated version of Boost with this change, we can just add {{BOOST_CONFIG_SUPPRESS_OUTDATED_MESSAGE}}
to the pre-processor definitions and delete this patch. But it is necessary for now (and even
upstream they realized this code was awful).

> Boost emits warning repeatedly
> ------------------------------
>
>                 Key: MESOS-8556
>                 URL: https://issues.apache.org/jira/browse/MESOS-8556
>             Project: Mesos
>          Issue Type: Improvement
>         Environment: Windows 10 with Boost 1.65.0
>            Reporter: Andrew Schwartzmeyer
>            Assignee: Andrew Schwartzmeyer
>            Priority: Minor
>              Labels: build, windows
>
> Boost emits the following warning when its included in our build:
> > Unknown compiler version - please run the configure tests and report the results
> It's not a bug, and it doesn't break anything. But it's annoying. And it's still in 1.65.0,
but will be fixed in 1.65.1. It's just due to an out-of-date configuration file detecting
the MSVC version (in this case, VS 2017).
> [What to patch.|https://stackoverflow.com/questions/30760889/unknown-compiler-version-while-compiling-boost-with-msvc-14-0-vs-2015]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message