From issues-return-46308-archive-asf-public=cust-asf.ponee.io@mesos.apache.org Thu Feb 1 07:27:10 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id 1C866180652 for ; Thu, 1 Feb 2018 07:27:10 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 0C6CD160C44; Thu, 1 Feb 2018 06:27:10 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 5347F160C26 for ; Thu, 1 Feb 2018 07:27:09 +0100 (CET) Received: (qmail 42517 invoked by uid 500); 1 Feb 2018 06:27:08 -0000 Mailing-List: contact issues-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@mesos.apache.org Delivered-To: mailing list issues@mesos.apache.org Received: (qmail 42508 invoked by uid 99); 1 Feb 2018 06:27:08 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 01 Feb 2018 06:27:08 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 0D633198C30 for ; Thu, 1 Feb 2018 06:27:08 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.261 X-Spam-Level: X-Spam-Status: No, score=-109.261 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, KAM_LOTSOFHASH=0.25, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id e3_tRMW3Cx94 for ; Thu, 1 Feb 2018 06:27:03 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 390C65F3B5 for ; Thu, 1 Feb 2018 06:27:02 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id DA53DE0115 for ; Thu, 1 Feb 2018 06:27:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 1F00321E82 for ; Thu, 1 Feb 2018 06:27:00 +0000 (UTC) Date: Thu, 1 Feb 2018 06:27:00 +0000 (UTC) From: "Greg Mann (JIRA)" To: issues@mesos.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (MESOS-8184) Implement master's AcknowledgeOfferOperationMessage handler. MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/MESOS-8184?page=3Dcom.atlassian= .jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D1634= 8078#comment-16348078 ]=20 Greg Mann commented on MESOS-8184: ---------------------------------- {code} commit bcd7fd8ec0b42fb59c1d1f824dea60907fb82308 Author: Gaston Kleiman Date: Wed Jan 31 12:59:28 2018 -0800 Made devolving `v1::scheduler::Call::SUBSCRIBE` more robust. `devolve(const v1::scheduler::Call& call)` is called by `master::receive()` and by `Master::Http::scheduler()` before the input is validated, so it should check if optional fields are set before accessing them. Review: https://reviews.apache.org/r/65357/ {code} {code} commit 0c794bd03fc40fc83d0ad0ac4b866807b95b7321 Author: Gaston Kleiman Date: Wed Jan 31 12:59:29 2018 -0800 Removed unnecesssary validations from `Master::receive()`. `validation::scheduler::call::validate(call)` is called at the top of `master::receive()`, so it doesn't need to validate the calls again. Review: https://reviews.apache.org/r/65358/ {code} {code} commit fccdba9af710fe9a32b0de245df31ad959851167 Author: Gaston Kleiman Date: Wed Jan 31 12:59:34 2018 -0800 Added an extra CHECK to `Master::acknowledge()`. The acknowledge call is validated before being passed to `Master::acknowledge`, so it is safe to assume that `acknowledge.uuid()= ` will be valid. Added a CHECK to detect problems in the validation code or changes in the code paths. Review: https://reviews.apache.org/r/65359/ {code} {code} commit 84ce9fda3c2d5885f2b4b99e62e0a32e851cf4b8 Author: Gaston Kleiman Date: Wed Jan 31 12:59:38 2018 -0800 Made `master::receive()` drop `ACKNOWLEDGE_OPERATION_STATUS` calls. `Master::receive()` handles scheduler API calls sent by v0 API clients. `ACKNOWLEDGE_OPERATION_STATUS` is a v1-only API call, so `Master::receive()` should drop it. Review: https://reviews.apache.org/r/65360/ {code} {code} commit 0836715d1c29af8ad8ed8871eea741c93b390843 Author: Gaston Kleiman Date: Wed Jan 31 12:59:43 2018 -0800 Improved task status acknowledgement logging messages. Review: https://reviews.apache.org/r/65424/ {code} {code} commit a14db195cbac67a9fa9a7f6c0a16f358b755eff1 Author: Gaston Kleiman Date: Wed Jan 31 12:59:47 2018 -0800 Added special handling for devolving ACKNOWLEDGE_OPERATION_STATUS calls= . Review: https://reviews.apache.org/r/65361/ {code} > Implement master's AcknowledgeOfferOperationMessage handler. > ------------------------------------------------------------ > > Key: MESOS-8184 > URL: https://issues.apache.org/jira/browse/MESOS-8184 > Project: Mesos > Issue Type: Task > Reporter: Gast=C3=B3n Kleiman > Assignee: Gast=C3=B3n Kleiman > Priority: Major > Labels: mesosphere > > This handler should validate the message and forward it to the correspond= ing agent/ERP. -- This message was sent by Atlassian JIRA (v7.6.3#76005)