mesos-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Greg Mann (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MESOS-8184) Implement master's AcknowledgeOfferOperationMessage handler.
Date Thu, 01 Feb 2018 06:27:00 GMT

    [ https://issues.apache.org/jira/browse/MESOS-8184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16348078#comment-16348078
] 

Greg Mann commented on MESOS-8184:
----------------------------------

{code}
commit bcd7fd8ec0b42fb59c1d1f824dea60907fb82308
Author: Gaston Kleiman <gaston@mesosphere.io>
Date:   Wed Jan 31 12:59:28 2018 -0800

    Made devolving `v1::scheduler::Call::SUBSCRIBE` more robust.

    `devolve(const v1::scheduler::Call& call)` is called by
    `master::receive()` and by `Master::Http::scheduler()` before the input
    is validated, so it should check if optional fields are set before
    accessing them.

    Review: https://reviews.apache.org/r/65357/
{code}
{code}
commit 0c794bd03fc40fc83d0ad0ac4b866807b95b7321
Author: Gaston Kleiman <gaston@mesosphere.io>
Date:   Wed Jan 31 12:59:29 2018 -0800

    Removed unnecesssary validations from `Master::receive()`.

    `validation::scheduler::call::validate(call)` is called at the top of
    `master::receive()`, so it doesn't need to validate the calls again.

    Review: https://reviews.apache.org/r/65358/
{code}
{code}
commit fccdba9af710fe9a32b0de245df31ad959851167
Author: Gaston Kleiman <gaston@mesosphere.io>
Date:   Wed Jan 31 12:59:34 2018 -0800

    Added an extra CHECK to `Master::acknowledge()`.

    The acknowledge call is validated before being passed to
    `Master::acknowledge`, so it is safe to assume that `acknowledge.uuid()`
    will be valid.

    Added a CHECK to detect problems in the validation code or changes in
    the code paths.

    Review: https://reviews.apache.org/r/65359/
{code}
{code}
commit 84ce9fda3c2d5885f2b4b99e62e0a32e851cf4b8
Author: Gaston Kleiman <gaston@mesosphere.io>
Date:   Wed Jan 31 12:59:38 2018 -0800

    Made `master::receive()` drop `ACKNOWLEDGE_OPERATION_STATUS` calls.

    `Master::receive()` handles scheduler API calls sent by v0 API clients.
    `ACKNOWLEDGE_OPERATION_STATUS` is a v1-only API call, so
    `Master::receive()` should drop it.

    Review: https://reviews.apache.org/r/65360/
{code}
{code}
commit 0836715d1c29af8ad8ed8871eea741c93b390843
Author: Gaston Kleiman <gaston@mesosphere.io>
Date:   Wed Jan 31 12:59:43 2018 -0800

    Improved task status acknowledgement logging messages.

    Review: https://reviews.apache.org/r/65424/
{code}
{code}
commit a14db195cbac67a9fa9a7f6c0a16f358b755eff1
Author: Gaston Kleiman <gaston@mesosphere.io>
Date:   Wed Jan 31 12:59:47 2018 -0800

    Added special handling for devolving ACKNOWLEDGE_OPERATION_STATUS calls.

    Review: https://reviews.apache.org/r/65361/
{code}

> Implement master's AcknowledgeOfferOperationMessage handler.
> ------------------------------------------------------------
>
>                 Key: MESOS-8184
>                 URL: https://issues.apache.org/jira/browse/MESOS-8184
>             Project: Mesos
>          Issue Type: Task
>            Reporter: Gastón Kleiman
>            Assignee: Gastón Kleiman
>            Priority: Major
>              Labels: mesosphere
>
> This handler should validate the message and forward it to the corresponding agent/ERP.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message