mesos-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gilbert Song (JIRA)" <>
Subject [jira] [Updated] (MESOS-7704) Remove use of #pragma comment (lib, "IPHLPAPI.lib").
Date Wed, 17 Jan 2018 20:28:01 GMT


Gilbert Song updated MESOS-7704:
    Summary: Remove use of #pragma comment (lib, "IPHLPAPI.lib").  (was: Remove use of #pragma

> Remove use of #pragma comment (lib, "IPHLPAPI.lib").
> ----------------------------------------------------
>                 Key: MESOS-7704
>                 URL:
>             Project: Mesos
>          Issue Type: Bug
>         Environment: Windows
>            Reporter: Andrew Schwartzmeyer
>            Assignee: Andrew Schwartzmeyer
>            Priority: Major
>             Fix For: 1.5.0
> Commits 0a1e94d84, 5a7c8d8ef, and f7f661525 introduced the pattern of linking to a Windows
system library with the {{#pragma comment(lib, "IPHLPAPI.lib")}}, instead of adding the library
to the correct place in the CMake build system.
> While this works, we should be consistent in the way we link to libraries, so this code
should be removed and {{IPHLPAPI.lib}} should be added to stout's {{LFLAGS}}.

This message was sent by Atlassian JIRA

View raw message