Mailing-List: contact issues-help@mesos.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@mesos.apache.org
Date: Tue, 5 Dec 2017 23:06:00 +0000 (UTC)
From: "Benjamin Mahler (JIRA)" <jira@apache.org>
To: issues@mesos.apache.org
Message-ID: <JIRA.13123029.1512515055000.393532.1512515160795@Atlassian.JIRA>
In-Reply-To: <JIRA.13123029.1512515055000@Atlassian.JIRA>
References: <JIRA.13123029.1512515055000@Atlassian.JIRA> <JIRA.13123029.1512515055448@jira-lw-us.apache.org>
Subject: [jira] [Commented] (MESOS-8302) Improve master failover
 performance.
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Tue, 05 Dec 2017 23:06:06 -0000


    [ https://issues.apache.org/jira/browse/MESOS-8302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16279335#comment-16279335 ] 

Benjamin Mahler commented on MESOS-8302:
----------------------------------------

{noformat}
commit 8ea9245e5c6d1f8b84219eb5d8b36f3cec1c6a7a
Author: Dmitry Zhuk <dzhuk@twopensource.com>
Date:   Wed Nov 22 11:59:17 2017 -0700

    Optimized resources logging in master.

    When master logs agent or task resources, it uses `operator <<` for raw
    protobuf data, which outputs resources in JSON format, and is rather
    slow. However resources are known to be valid and refined when logged by
    master, so it's faster to use `operator <<` after protobuf is converted
    to `Resources`.

    Review: https://reviews.apache.org/r/63959/
{noformat}

{noformat}
commit 24550e7b863fee371877ea9d1d9153e0f5054155
Author: Dmitry Zhuk <dzhuk@twopensource.com>
Date:   Wed Nov 29 18:47:13 2017 -0800

    Improved master failover performance by avoiding resource conversions.

    RepeatedPtrField<Resource> can be implicitly converted to Resources,
    leading to hidden multiple resources conversions on performance-critical
    paths in master. For example, operator += relies on implicit
    conversion, when invoked with RepeatedPtrField<Resource> argument.
    Using protobuf also implies data validation and sanitization, e.g. when
    converting to Resources, as protobuf generally comes from untrusted
    sources. By doing conversion only once, and then reusing the result,
    we save on these checks as well, as operations on Resources are
    generally faster as they can trust data in Resources.

    Review: https://reviews.apache.org/r/64028/
{noformat}

{noformat}
commit b7ad2c0d4e7308a70049a6a04f19e3709df0e539
Author: Dmitry Zhuk <dzhuk@twopensource.com>
Date:   Tue Nov 21 10:11:46 2017 -0800

    Preallocated buffer for resources conversion.

    When converting collections of protobuf `Resource` to `Resources`,
    `std::vector` could be resized several times. This patch ensures that
    there is enough capacity to fit all resources in `vector` and avoid
    resizes.

    Review: https://reviews.apache.org/r/63960/
{noformat}

> Improve master failover performance.
> ------------------------------------
>
>                 Key: MESOS-8302
>                 URL: https://issues.apache.org/jira/browse/MESOS-8302
>             Project: Mesos
>          Issue Type: Improvement
>          Components: master
>            Reporter: Benjamin Mahler
>            Assignee: Dmitry Zhuk
>
> This is somewhat more like an epic, but will track the different improvements here for now.


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)