mesos-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "James Peach (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (MESOS-8366) Replace the command executor with the default executor.
Date Fri, 29 Dec 2017 04:52:00 GMT

    [ https://issues.apache.org/jira/browse/MESOS-8366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16305959#comment-16305959
] 

James Peach edited comment on MESOS-8366 at 12/29/17 4:51 AM:
--------------------------------------------------------------

Issues that I have found so far:

# Tests that restart the agent are now required to specify a fixed {{slaveId}}
# Tests that inspect the task sandbox need to now find the nested container sandbox
# Tests are likely to require additional expectations (since both the executor and task containers
might trigger them)
# The IO Switchboard doesn't work in local mode, which breaks command checks.
# Tests that depend on manipulating or intercepting protobuf messages from the executor (e.g.
{{MasterTest.AgentRestartNoReregister}})

I fixed the `FetcherCacheTest` suite, leaving the following non-root test failures:
{noformat}
[==========] 310 tests from 130 test cases ran. (367254 ms total)
[  PASSED  ] 292 tests.
[  FAILED  ] 18 tests, listed below:
[  FAILED  ] CommandExecutorCheckTest.CommandCheckTimeout
[  FAILED  ] ContainerLoggerTest.DefaultToSandbox
[  FAILED  ] FetcherCacheHttpTest.HttpCachedConcurrent
[  FAILED  ] FetcherTest.Unzip_ExtractFile
[  FAILED  ] HealthCheckTest.HealthyTask
[  FAILED  ] HealthCheckTest.CheckCommandTimeout
[  FAILED  ] MasterTest.AgentRestartNoReregister
[  FAILED  ] SlaveRecoveryTest/0.ReconnectExecutor, where TypeParam = mesos::internal::slave::MesosContainerizer
[  FAILED  ] SlaveRecoveryTest/0.RecoverTerminatedExecutor, where TypeParam = mesos::internal::slave::MesosContainerizer
[  FAILED  ] SlaveRecoveryTest/0.Reboot, where TypeParam = mesos::internal::slave::MesosContainerizer
[  FAILED  ] SlaveRecoveryTest/0.RegisterDisconnectedSlave, where TypeParam = mesos::internal::slave::MesosContainerizer
[  FAILED  ] SlaveRecoveryTest/0.MultipleFrameworks, where TypeParam = mesos::internal::slave::MesosContainerizer
[  FAILED  ] SlaveTest.ShutdownUnregisteredExecutor
[  FAILED  ] SlaveTest.GetExecutorInfoForTaskWithContainer
[  FAILED  ] ContentType/AgentAPITest.GetState/1, where GetParam() = application/json
[  FAILED  ] ContentType/AgentAPITest.LaunchNestedContainerSessionUnauthorized/1, where GetParam()
= application/json
[  FAILED  ] DiskResource/PersistentVolumeTest.AccessPersistentVolume/2, where GetParam()
= (1, 0)
[  FAILED  ] DiskResource/PersistentVolumeTest.DestroyPersistentVolumeMultipleTasks/0, where
GetParam() = (0, 0)
{noformat}


was (Author: jamespeach):
Issues that I have found so far:

# Tests that restart the agent are now required to specify a fixed {{slaveId}}
# Tests that inspect the task sandbox need to now find the nested container sandbox
# Tests are likely to require additional expectations (since both the executor and task containers
might trigger them)
# The IO Switchboard doesn't work in local mode, which breaks command checks.

I fixed the `FetcherCacheTest` suite, leaving the following non-root test failures:
{noformat}
[==========] 310 tests from 130 test cases ran. (367254 ms total)
[  PASSED  ] 292 tests.
[  FAILED  ] 18 tests, listed below:
[  FAILED  ] CommandExecutorCheckTest.CommandCheckTimeout
[  FAILED  ] ContainerLoggerTest.DefaultToSandbox
[  FAILED  ] FetcherCacheHttpTest.HttpCachedConcurrent
[  FAILED  ] FetcherTest.Unzip_ExtractFile
[  FAILED  ] HealthCheckTest.HealthyTask
[  FAILED  ] HealthCheckTest.CheckCommandTimeout
[  FAILED  ] MasterTest.AgentRestartNoReregister
[  FAILED  ] SlaveRecoveryTest/0.ReconnectExecutor, where TypeParam = mesos::internal::slave::MesosContainerizer
[  FAILED  ] SlaveRecoveryTest/0.RecoverTerminatedExecutor, where TypeParam = mesos::internal::slave::MesosContainerizer
[  FAILED  ] SlaveRecoveryTest/0.Reboot, where TypeParam = mesos::internal::slave::MesosContainerizer
[  FAILED  ] SlaveRecoveryTest/0.RegisterDisconnectedSlave, where TypeParam = mesos::internal::slave::MesosContainerizer
[  FAILED  ] SlaveRecoveryTest/0.MultipleFrameworks, where TypeParam = mesos::internal::slave::MesosContainerizer
[  FAILED  ] SlaveTest.ShutdownUnregisteredExecutor
[  FAILED  ] SlaveTest.GetExecutorInfoForTaskWithContainer
[  FAILED  ] ContentType/AgentAPITest.GetState/1, where GetParam() = application/json
[  FAILED  ] ContentType/AgentAPITest.LaunchNestedContainerSessionUnauthorized/1, where GetParam()
= application/json
[  FAILED  ] DiskResource/PersistentVolumeTest.AccessPersistentVolume/2, where GetParam()
= (1, 0)
[  FAILED  ] DiskResource/PersistentVolumeTest.DestroyPersistentVolumeMultipleTasks/0, where
GetParam() = (0, 0)
{noformat}

> Replace the command executor with the default executor.
> -------------------------------------------------------
>
>                 Key: MESOS-8366
>                 URL: https://issues.apache.org/jira/browse/MESOS-8366
>             Project: Mesos
>          Issue Type: Bug
>          Components: agent, executor
>            Reporter: James Peach
>            Assignee: James Peach
>
> We should use the default executor for all the cases that currently invoke the command
executor. This is a straightforward matter of implementing `LaunchTask` in the default executor,
and then fixing all the test assumptions that this change will break.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message