Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id E9DA5200D33 for ; Wed, 8 Nov 2017 17:25:05 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id E8481160C02; Wed, 8 Nov 2017 16:25:05 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 4341F160BDA for ; Wed, 8 Nov 2017 17:25:05 +0100 (CET) Received: (qmail 14707 invoked by uid 500); 8 Nov 2017 16:25:04 -0000 Mailing-List: contact issues-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@mesos.apache.org Delivered-To: mailing list issues@mesos.apache.org Received: (qmail 14693 invoked by uid 99); 8 Nov 2017 16:25:04 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 08 Nov 2017 16:25:04 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 80A3AD1972 for ; Wed, 8 Nov 2017 16:25:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.201 X-Spam-Level: X-Spam-Status: No, score=-99.201 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, NORMAL_HTTP_TO_IP=0.001, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id tBZr-k96ZDj4 for ; Wed, 8 Nov 2017 16:25:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 7BB8261A5E for ; Wed, 8 Nov 2017 16:25:02 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id BB884E0F7D for ; Wed, 8 Nov 2017 16:25:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 196EF241A8 for ; Wed, 8 Nov 2017 16:25:01 +0000 (UTC) Date: Wed, 8 Nov 2017 16:25:01 +0000 (UTC) From: "James Peach (JIRA)" To: issues@mesos.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (MESOS-8169) master validation incorrectly rejects slaves, buggy executorID checking MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Wed, 08 Nov 2017 16:25:06 -0000 [ https://issues.apache.org/jira/browse/MESOS-8169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16244255#comment-16244255 ] James Peach commented on MESOS-8169: ------------------------------------ {noformat} commit 677305f0b8a161d87d16ff156f58d2b0789c15e0 (HEAD -> master, origin/master, origin/HEAD) Author: James Peach Date: Tue Nov 7 16:59:27 2017 -0800 Added a test for ExecutorID validation in ReregisterSlaveMessage. Added a test to ensure that the ReregisterSlaveMessage validation correctly allows duplicate ExecutorIDs as long as they are scoped to different frameworks. Review: https://reviews.apache.org/r/63642/ {noformat} > master validation incorrectly rejects slaves, buggy executorID checking > ----------------------------------------------------------------------- > > Key: MESOS-8169 > URL: https://issues.apache.org/jira/browse/MESOS-8169 > Project: Mesos > Issue Type: Bug > Affects Versions: 1.4.0 > Reporter: James DeFelice > Assignee: James DeFelice > Labels: mesosphere > Fix For: 1.5.0 > > > proposed fix: https://github.com/apache/mesos/pull/248 > I observed this in my environment, where I had two frameworks that used the same ExecutorID and then triggered a master failover. The master refuses to reregister the slave because it's not considering the owning-framework of the ExecutorID when computing ExecutorID uniqueness, and concludes (incorrectly) that there's an erroneous duplicate executor ID: > {code} > W1103 00:33:42.509891 19638 master.cpp:6008] Dropping re-registration of agent at slave(1)@10.2.0.7:5051 because it sent an invalid re-registration: Executor has a duplicate ExecutorID 'default' > {code} > (yes, "default" is probably a terrible name for an ExecutorID - that's a separate discussion!) > /cc [~neilc] -- This message was sent by Atlassian JIRA (v6.4.14#64029)