Mailing-List: contact issues-help@mesos.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@mesos.apache.org
Date: Fri, 1 Sep 2017 17:14:00 +0000 (UTC)
From: "Yan Xu (JIRA)" <jira@apache.org>
To: issues@mesos.apache.org
Message-ID: <JIRA.13034701.1484322949000.10825.1504286040333@Atlassian.JIRA>
In-Reply-To: <JIRA.13034701.1484322949000@Atlassian.JIRA>
References: <JIRA.13034701.1484322949000@Atlassian.JIRA> <JIRA.13034701.1484322949982@jira-lw-us.apache.org>
Subject: [jira] [Commented] (MESOS-6918) Prometheus exporter endpoints for
 metrics
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Fri, 01 Sep 2017 17:14:09 -0000


    [ https://issues.apache.org/jira/browse/MESOS-6918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16150848#comment-16150848 ] 

Yan Xu commented on MESOS-6918:
-------------------------------

I think [~bmahler]'s questions (and mine below) suggest we need a (mini) design doc about the overarching methodology here. The summary of each review and the existing comments in this JIRA are not providing enough of a high level design so the justification for each patch is not clear enough.

A few more questions:

- I understand that complex Prometheus metric types such as {{summary}} require some more data than what is currently provided so we need to add them somewhere. But they should be added to Mesos' existing "core" metrics classes only if they are generic (backwards compatible) improvements that make sense regardless of the Prometheus support. I believe this is indeed your goal but we need to articulate how current timer/statistics modeling is lacking/wrong.
-- There are some patches that remove history from simple metrics because it doesn't make sense. Should the history then be put in another base type that {{Counter}} and {{Gauge}} don't derive from?
- After the above is done, is Prometheus merely a specific format? If that's the case, can we encapsulate the formatting logic into a formatter class/method instead of the main metric endpoint actor?


> Prometheus exporter endpoints for metrics
> -----------------------------------------
>
>                 Key: MESOS-6918
>                 URL: https://issues.apache.org/jira/browse/MESOS-6918
>             Project: Mesos
>          Issue Type: Bug
>          Components: statistics
>            Reporter: James Peach
>            Assignee: James Peach
>
> There are a couple of [Prometheus|https://prometheus.io] metrics exporters for Mesos, of varying quality. Since the Mesos stats system actually knows about statistics data types and semantics, and Mesos has reasonable HTTP support we could add Prometheus metrics endpoints to directly expose statistics in [Prometheus wire format|https://prometheus.io/docs/instrumenting/exposition_formats/], removing the need for operators to run separate exporter processes.


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)