mesos-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Armand Grillet (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MESOS-7924) Add a javascript linter to the webui.
Date Mon, 11 Sep 2017 10:03:02 GMT

    [ https://issues.apache.org/jira/browse/MESOS-7924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16161003#comment-16161003
] 

Armand Grillet commented on MESOS-7924:
---------------------------------------

I have worked on the review request linked above over the weekend. This is currently a WIP
that I have published mainly to get your review concerning the file {{.eslintrc.js}}, this
file defines which errors/warnings should the linter display thus a correctly opinionated
review of it is important. I have created the one in the patch by running {{eslint --init}}
and answering these questions without being too careful:

{code}
(web-ui) static (eslint) $ eslint --init
? How would you like to configure ESLint? Inspect your JavaScript file(s)
? Which file(s), path(s), or glob(s) should be examined? /Users/Armand/Code/apache-mesos/src/webui/master/static/js/app.js
? What format do you want your config file to be in? JavaScript
? Are you using ECMAScript 6 features? No
? Where will your code run? Browser
? Do you use CommonJS? No
? Do you use JSX? No
{code}

The rest of the patch is similar to what we do for our Python linter. This means adding a
{{.gitignore}} to the repository which is not conventional but already done in {{src/python/cli_new}},
adding {{.virtualenv}} to the root {{.gitignore}} is also a possibility.

> Add a javascript linter to the webui.
> -------------------------------------
>
>                 Key: MESOS-7924
>                 URL: https://issues.apache.org/jira/browse/MESOS-7924
>             Project: Mesos
>          Issue Type: Improvement
>          Components: webui
>            Reporter: Benjamin Mahler
>            Assignee: Armand Grillet
>              Labels: tech-debt
>
> As far as I can tell, javascript linters (e.g. ESLint) help catch some functional errors
as well, for example, we've made some "strict" mistakes a few times that ESLint can catch:
MESOS-6624, MESOS-7912.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message