mesos-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benno Evers (JIRA)" <>
Subject [jira] [Commented] (MESOS-7773) HTTP request validation stage is not explicit.
Date Mon, 14 Aug 2017 10:56:00 GMT


Benno Evers commented on MESOS-7773:

While we're at it, we should also make sure that we always return BadRequest on malformed
user input instead of `CHECK`-ing and aborting. Right now, there are some places where it
looks like we're asserting certain properties of user-passed protobuf messages, for example
the local authorizer seems to `CHECK` that certain fields of the passed protobuf message was
set. (src/authorizer/local/authorizer.cpp:312)

> HTTP request validation stage is not explicit.
> ----------------------------------------------
>                 Key: MESOS-7773
>                 URL:
>             Project: Mesos
>          Issue Type: Bug
>          Components: libprocess
>            Reporter: Alexander Rukletsov
>              Labels: mesosphere, reliability
> Currently we validate HTTP requests in multiple places in libprocess, for instance {{ProcessManager::handle()}},
{{StreamingRequestDecoder::decode()}}, {{process::parse()}}. To improve error handling when
dealing with malformed HTTP requests (including libprocess messages), consider introducing
a validation stage and / or make sure {{Request}} and all its components are in valid state
before we start using it.

This message was sent by Atlassian JIRA

View raw message