mesos-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "James Peach (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MESOS-7643) The order of isolators provided in '--isolation' flag is not preserved and instead sorted alphabetically
Date Mon, 14 Aug 2017 04:10:00 GMT

    [ https://issues.apache.org/jira/browse/MESOS-7643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16125203#comment-16125203
] 

James Peach commented on MESOS-7643:
------------------------------------

Actually making the necessary checks requires some sort of set. I think you'd need to keep
a parallel vector of isolators and manipulate both the set and the vector as needed. My preference
would be to land my current patch then make these changes on top :)

> The order of isolators provided in '--isolation' flag is not preserved and instead sorted
alphabetically
> --------------------------------------------------------------------------------------------------------
>
>                 Key: MESOS-7643
>                 URL: https://issues.apache.org/jira/browse/MESOS-7643
>             Project: Mesos
>          Issue Type: Bug
>          Components: containerization
>    Affects Versions: 1.1.2, 1.2.0, 1.3.0
>            Reporter: Michael Cherny
>            Assignee: Gilbert Song
>            Priority: Critical
>              Labels: isolation
>
> According to documentation and comments in code the order of the entries in the --isolation
flag should specify the ordering of the isolators. Specifically, the `create` and `prepare`
calls for each isolator should run serially in the order in which they appear in the --isolation
flag, while the `cleanup` call should be serialized in reverse order (with exception of filesystem
isolator which is always first).
> But in fact, the isolators provided in '--isolation' flag are sorted alphabetically.
> That happens in [this line of code|https://github.com/apache/mesos/blob/master/src/slave/containerizer/mesos/containerizer.cpp#L377].
In this line use of 'set<string>' is done (apparently instead of list or vector) and
set is a sorted container.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message