Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id B0D24200CE5 for ; Sat, 8 Jul 2017 02:51:09 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id AD9CB16A60F; Sat, 8 Jul 2017 00:51:09 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id F37FF16A60C for ; Sat, 8 Jul 2017 02:51:08 +0200 (CEST) Received: (qmail 20894 invoked by uid 500); 8 Jul 2017 00:51:08 -0000 Mailing-List: contact issues-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@mesos.apache.org Delivered-To: mailing list issues@mesos.apache.org Received: (qmail 20885 invoked by uid 99); 8 Jul 2017 00:51:08 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 08 Jul 2017 00:51:08 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id B1E4FC05A7 for ; Sat, 8 Jul 2017 00:51:07 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -100.002 X-Spam-Level: X-Spam-Status: No, score=-100.002 tagged_above=-999 required=6.31 tests=[RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id nPMwqlkZJHBb for ; Sat, 8 Jul 2017 00:51:07 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 5422F5F60D for ; Sat, 8 Jul 2017 00:51:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 5CBC9E0D45 for ; Sat, 8 Jul 2017 00:51:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 15B6724692 for ; Sat, 8 Jul 2017 00:51:00 +0000 (UTC) Date: Sat, 8 Jul 2017 00:51:00 +0000 (UTC) From: "Avinash Sridharan (JIRA)" To: issues@mesos.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (MESOS-7772) Copy-n-paste error in slave/main.cpp MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Sat, 08 Jul 2017 00:51:09 -0000 [ https://issues.apache.org/jira/browse/MESOS-7772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16078872#comment-16078872 ] Avinash Sridharan commented on MESOS-7772: ------------------------------------------ https://reviews.apache.org/r/60720/ https://reviews.apache.org/r/60723/ > Copy-n-paste error in slave/main.cpp > ------------------------------------ > > Key: MESOS-7772 > URL: https://issues.apache.org/jira/browse/MESOS-7772 > Project: Mesos > Issue Type: Bug > Components: agent > Affects Versions: 1.4.0 > Reporter: Benjamin Bannier > Assignee: Avinash Sridharan > Labels: coverity, mesosphere > > Coverity diagnosed a copy-n-paste error in {{slave/main.cpp}} (https://scan5.coverity.com/reports.htm#v10074/p10429/fileInstanceId=120155401&defectInstanceId=33592186&mergedDefectId=1414687+1+Comment), > {noformat} > 323 } else if (flags.ip6.isSome()) { > CID 1414687 (#1 of 1): Copy-paste error (COPY_PASTE_ERROR) > copy_paste_error: ip in flags.ip looks like a copy-paste error. > Should it say ip6 instead? > 324 os::setenv("LIBPROCESS_IP6", flags.ip.get()); > 325 } > {noformat} > We check the incorrect IP for some value here (check on {{ip6}}, but use of {{ip}}), and it seems extremely likely we intended to use {{flags.ip6}}. -- This message was sent by Atlassian JIRA (v6.4.14#64029)