mesos-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benjamin Bannier (JIRA)" <j...@apache.org>
Subject [jira] [Created] (MESOS-7772) Copy-n-paste error in slave/main.cpp
Date Fri, 07 Jul 2017 23:02:00 GMT
Benjamin Bannier created MESOS-7772:
---------------------------------------

             Summary: Copy-n-paste error in slave/main.cpp
                 Key: MESOS-7772
                 URL: https://issues.apache.org/jira/browse/MESOS-7772
             Project: Mesos
          Issue Type: Bug
          Components: agent
    Affects Versions: 1.4.0
            Reporter: Benjamin Bannier
            Assignee: Avinash Sridharan


Coverity diagnosed a copy-n-paste error in {{slave/main.cpp}} (https://scan5.coverity.com/reports.htm#v10074/p10429/fileInstanceId=120155401&defectInstanceId=33592186&mergedDefectId=1414687+1+Comment),

{noformat}
323  } else if (flags.ip6.isSome()) {
CID 1414687 (#1 of 1): Copy-paste error (COPY_PASTE_ERROR)
copy_paste_error: ip in flags.ip looks like a copy-paste error.
   	Should it say ip6 instead?
324    os::setenv("LIBPROCESS_IP6", flags.ip.get());
325  }
{noformat}

We check the incorrect IP for some value here (check on {{ip6}}, but use of {{ip}}), and it
seems extremely likely we intended to use {{flags.ip6}}.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message