mesos-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yan Xu (JIRA)" <>
Subject [jira] [Commented] (MESOS-7753) `log.LearnedMessage` could be rejected due to being sent from '@'
Date Mon, 03 Jul 2017 23:26:00 GMT


Yan Xu commented on MESOS-7753:

A few things in consideration:

- We cannot simply whitelist {{@}} in MESOS-7401 otherwise the protection mechanism
is rendered useless. 
- Even though some messages are not supposed to have a "return address", it makes sense to
always require a non-empty {{from}} address for actor to actor communication.
- For non-testing libprocess communication in Mesos it makes sense to assume all messages
are sent by libprocess actors.

So for this the easiest fix is probably just give the {{LearnedMessage}} a sender: define
a simple {{RequestProcess}}, in contrast with {{ReqResProcess}}, which is used for other replicated
log messages.

Of course no attempt has been made in the replicated log to really verify that the learned
message is sent by a coordinator so this is simply to make the replicated log compliant with

/cc [] [~jieyu]

> `log.LearnedMessage` could be rejected due to being sent from '@'
> --------------------------------------------------------------------------
>                 Key: MESOS-7753
>                 URL:
>             Project: Mesos
>          Issue Type: Bug
>          Components: replicated log
>            Reporter: Yan Xu
> This is due to the use of
which sets the message's {{from}} field to an empty UPID.
> The rationale for using this form is that there's no intended response for this message.
However with MESOS-7401, this message could be rejected.

This message was sent by Atlassian JIRA

View raw message