mesos-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Park (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MESOS-7195) Use C++11 variadic templates for process::dispatch/defer/delay/async/run
Date Tue, 18 Jul 2017 22:08:00 GMT

    [ https://issues.apache.org/jira/browse/MESOS-7195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16092261#comment-16092261
] 

Michael Park commented on MESOS-7195:
-------------------------------------

[~dzhuk] the above is an outline of why we currently don't have a variadic template implementation
for defer/dispatch currently.
I spoke to [~benjaminhindman] yesterday about changing the API such that few places where
we have overloaded member functions,
the user would be required to pass in a lambda instead. Also, I think the refactoring work
will be easier once we upgrade to C++14.

So here's my proposal:
(1) We move ahead with your patches to get the performance improvements
(2) Upgrade to C++14
(3) Follow-up with the refactoring work

What do you think?

> Use C++11 variadic templates for process::dispatch/defer/delay/async/run
> ------------------------------------------------------------------------
>
>                 Key: MESOS-7195
>                 URL: https://issues.apache.org/jira/browse/MESOS-7195
>             Project: Mesos
>          Issue Type: Improvement
>          Components: libprocess
>            Reporter: Yan Xu
>
> These methods are currently implemented using {{REPEAT_FROM_TO}} (i.e., {{BOOST_PP_REPEAT_FROM_TO}}):
> {code:title=}
> REPEAT_FROM_TO(1, 11, TEMPLATE, _) // Args A0 -> A9.
> {code}
> This means we have to bump up the number of repetition whenever we have a new method
with more args.
> Seems like we can replace this with C++11 variadic templates.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message