mesos-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benjamin Mahler (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (MESOS-6972) Improve performance of protobuf message passing by removing RepeatedPtrField to vector conversion.
Date Thu, 08 Jun 2017 18:18:18 GMT

    [ https://issues.apache.org/jira/browse/MESOS-6972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16043178#comment-16043178
] 

Benjamin Mahler commented on MESOS-6972:
----------------------------------------

[~dzhuk] great, yeah I was thinking of this option as well but wasn't sure if this works when
we use arena allocation, since Swap performs deep copies if one side is from an arena and
the other is not:

https://developers.google.com/protocol-buffers/docs/reference/arenas#message-class-methods

> Improve performance of protobuf message passing by removing RepeatedPtrField to vector
conversion.
> --------------------------------------------------------------------------------------------------
>
>                 Key: MESOS-6972
>                 URL: https://issues.apache.org/jira/browse/MESOS-6972
>             Project: Mesos
>          Issue Type: Improvement
>            Reporter: Benjamin Mahler
>              Labels: tech-debt
>
> Currently, all protobuf message handlers must take a {{vector}} for repeated fields,
rather than a {{RepeatedPtrField}}.
> This requires that a copy be performed of the repeated field's entries (see [here|https://github.com/apache/mesos/blob/9228ebc239dac42825390bebc72053dbf3ae7b09/3rdparty/libprocess/include/process/protobuf.hpp#L78-L87]),
which can be very expensive in some cases. We should avoid requiring this expense on the callers.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message