mesos-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benjamin Bannier (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (MESOS-6115) Source tree contains compiled protobuf source
Date Wed, 14 Jun 2017 08:53:00 GMT

     [ https://issues.apache.org/jira/browse/MESOS-6115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Benjamin Bannier updated MESOS-6115:
------------------------------------
    Description: 
Stout's {{protobuf_tests.cpp}} uses checked in, generated protobuf files {{protobuf_tests.pb.h}}
and {{protobuf_tests.pb.cc}}.

These files are
* not meant to be edited,
* might require updates whenever protobuf is updated, and
* likely do not follow Mesos coding standards.

We should try to remove them from the source tree.

  was:
Stout's {{protobuf_tests.cpp}} uses checked in, generated protobuf files {{protobuf_tests.pb.h}}
and {{protobuf_tests.pb.cc}}.

These files are
* not meant to be edited,
* might require updates whenever protobuf is updated, and
* likely do not follow Mesos coding standards.

We should try to remove them from the source tree; in fact {{protobuf_tests.cpp}} already
documents ways this could be achieved.


> Source tree contains compiled protobuf source
> ---------------------------------------------
>
>                 Key: MESOS-6115
>                 URL: https://issues.apache.org/jira/browse/MESOS-6115
>             Project: Mesos
>          Issue Type: Bug
>          Components: stout, test
>            Reporter: Benjamin Bannier
>              Labels: mesosphere, newbie
>
> Stout's {{protobuf_tests.cpp}} uses checked in, generated protobuf files {{protobuf_tests.pb.h}}
and {{protobuf_tests.pb.cc}}.
> These files are
> * not meant to be edited,
> * might require updates whenever protobuf is updated, and
> * likely do not follow Mesos coding standards.
> We should try to remove them from the source tree.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message