Mailing-List: contact issues-help@mesos.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@mesos.apache.org
Date: Thu, 11 May 2017 16:16:04 +0000 (UTC)
From: "Vinod Kone (JIRA)" <jira@apache.org>
To: issues@mesos.apache.org
Message-ID: <JIRA.13047364.1488385482000.188212.1494519364189@Atlassian.JIRA>
In-Reply-To: <JIRA.13047364.1488385482000@Atlassian.JIRA>
References: <JIRA.13047364.1488385482000@Atlassian.JIRA> <JIRA.13047364.1488385482328@jira-lw-us.apache.org>
Subject: [jira] [Updated] (MESOS-7193) Use of `GTEST_IS_THREADSAFE` in
 asserts is problematic.
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Thu, 11 May 2017 16:16:11 -0000


     [ https://issues.apache.org/jira/browse/MESOS-7193?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Vinod Kone updated MESOS-7193:
------------------------------
        Shepherd: Neil Conway
    Story Points: 5

> Use of `GTEST_IS_THREADSAFE` in asserts is problematic.
> -------------------------------------------------------
>
>                 Key: MESOS-7193
>                 URL: https://issues.apache.org/jira/browse/MESOS-7193
>             Project: Mesos
>          Issue Type: Bug
>          Components: libprocess, test
>            Reporter: Jan Schlicht
>            Assignee: Jan Schlicht
>              Labels: mesosphere
>
> Some test cases in libprocess use {{ASSERT_TRUE(GTEST_IS_THREADSAFE)}}. This is a misuse of that define, [the documentation in GTest says|https://github.com/google/googletest/blob/master/googletest/include/gtest/internal/gtest-port.h#L155-L163]:
> {noformat}
> Macros indicating which Google Test features are available (a macro
> is defined to 1 if the corresponding feature is supported;
> otherwise UNDEFINED -- it's never defined to 0.).  Google Test
> defines these macros automatically.  Code outside Google Test MUST
> NOT define them.
> {noformat}
> Currently, the use of {{GTEST_IS_THREADSAFE}} works fine in the assert, because it is defined to be {{1}}. But newer upstream versions of GTest use a more complicated define, that can yield to be undefined, causing compilation errors.


--
This message was sent by Atlassian JIRA
(v6.3.15#6346)