Mailing-List: contact issues-help@mesos.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@mesos.apache.org
Date: Thu, 27 Apr 2017 21:43:04 +0000 (UTC)
From: "Till Toenshoff (JIRA)" <jira@apache.org>
To: issues@mesos.apache.org
Message-ID: <JIRA.13067141.1493232507000.72397.1493329384384@Atlassian.JIRA>
In-Reply-To: <JIRA.13067141.1493232507000@Atlassian.JIRA>
References: <JIRA.13067141.1493232507000@Atlassian.JIRA> <JIRA.13067141.1493232507221@jira-lw-us.apache.org>
Subject: [jira] [Commented] (MESOS-7429) Allow isolators to inject
 task-specific environment variables.
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Thu, 27 Apr 2017 21:43:08 -0000


    [ https://issues.apache.org/jira/browse/MESOS-7429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15987753#comment-15987753 ] 

Till Toenshoff commented on MESOS-7429:
---------------------------------------

[~jpeach@apache.org] Custom executors currently have no way of receiving task specific environments injected by isolators - isolators do no mutate the {{TaskInfo}}. What we do for them already is passing the {{ContainerLaunchInfo}} returned {{environment}} on to the executor command environment {{execvpe}}.

> Allow isolators to inject task-specific environment variables.
> --------------------------------------------------------------
>
>                 Key: MESOS-7429
>                 URL: https://issues.apache.org/jira/browse/MESOS-7429
>             Project: Mesos
>          Issue Type: Improvement
>    Affects Versions: 1.2.0
>            Reporter: Till Toenshoff
>            Assignee: Till Toenshoff
>              Labels: containerizer, isolator, mesosphere
>
> For command tasks, we currently have no way for isolators to inject task specific environments into data path.
> Isolators in their {{prepare}} implementation can return a {{ContainerLaunchInfo}} which currently supports setting the member {{environment}} - but that is effective for the executor already and will get inherited by the task environment.
> Given that the command-executor is active in the host-fs context but the task may be running in a container-fs context ({{has_rootfs=true}}), using the above will possibly cause failures, depending on the nature of the variables set -- consider e.g. {{LD_LIBRARY_PATH}} as a fatal one.
> The command-executor does support the flag {{task_environment}} to receive environment variables which are meant exclusively for the task itself but not the executor.
> Runtime isolators (docker/runtime, appc/runtime) already make use of this flag. However, they do it in a way that is a bit unfortunate as it does not allow for other isolators to make use of it - there is no merging taking place in the containerizer.


--
This message was sent by Atlassian JIRA
(v6.3.15#6346)