Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id BD2E1200C5E for ; Fri, 7 Apr 2017 20:11:45 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id BBA4A160B84; Fri, 7 Apr 2017 18:11:45 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 174A6160B97 for ; Fri, 7 Apr 2017 20:11:44 +0200 (CEST) Received: (qmail 89398 invoked by uid 500); 7 Apr 2017 18:11:44 -0000 Mailing-List: contact issues-help@mesos.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@mesos.apache.org Delivered-To: mailing list issues@mesos.apache.org Received: (qmail 89295 invoked by uid 99); 7 Apr 2017 18:11:44 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 07 Apr 2017 18:11:44 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id D3168C047D for ; Fri, 7 Apr 2017 18:11:43 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.201 X-Spam-Level: X-Spam-Status: No, score=-99.201 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id WpG15Ocm8Xh1 for ; Fri, 7 Apr 2017 18:11:43 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id C8BC55FC7E for ; Fri, 7 Apr 2017 18:11:42 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 4614DE0D18 for ; Fri, 7 Apr 2017 18:11:42 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id A4C172406E for ; Fri, 7 Apr 2017 18:11:41 +0000 (UTC) Date: Fri, 7 Apr 2017 18:11:41 +0000 (UTC) From: "Andrew Schwartzmeyer (JIRA)" To: issues@mesos.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (MESOS-3872) Investigate adding color to `support/post-reviews.py` on Windows MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Fri, 07 Apr 2017 18:11:45 -0000 [ https://issues.apache.org/jira/browse/MESOS-3872?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Schwartzmeyer updated MESOS-3872: ---------------------------------------- Priority: Minor (was: Major) > Investigate adding color to `support/post-reviews.py` on Windows > ---------------------------------------------------------------- > > Key: MESOS-3872 > URL: https://issues.apache.org/jira/browse/MESOS-3872 > Project: Mesos > Issue Type: Bug > Components: general > Reporter: Alex Clemmer > Assignee: Alex Clemmer > Priority: Minor > Labels: mesosphere, windows > > From the comments: > # TODO(hausdorff): We have disabled colors for the diffs on Windows, as piping them through `subprocess` causes us to emit ANSI escape codes, which the command prompt doesn't recognize. Presumably we are being routed through some TTY that causes git to not emit the colors using `cmd`'s color codes API (which is entirely different from ANSI. See [1] for more information and MESOS-3872. > # > # [1] http://stackoverflow.com/questions/5921556/in-git-bash-on-windows-7-colors-display-as-code-when-running-cucumber-or-rspec -- This message was sent by Atlassian JIRA (v6.3.15#6346)